[AKS] Add option Ubuntu2604 to --os-sku for az aks nodepool add and az aks nodepool update#10054
Open
zachary-bailey wants to merge 3 commits into
Open
[AKS] Add option Ubuntu2604 to --os-sku for az aks nodepool add and az aks nodepool update#10054zachary-bailey wants to merge 3 commits into
zachary-bailey wants to merge 3 commits into
Conversation
❌Azure CLI Extensions Breaking Change Test
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the aks-preview extension to introduce a new OS SKU option (Ubuntu2604) for AKS node pool-related --os-sku parameters, along with the associated help text and extension versioning metadata.
Changes:
- Bump
aks-previewextension version to21.0.0b8and add a matching HISTORY entry. - Add
Ubuntu2604as a recognized OS SKU constant and include it in the--os-skuenum lists. - Update command help text to list
Ubuntu2604among supported Linux OS SKUs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumps the extension version to 21.0.0b8. |
| src/aks-preview/HISTORY.rst | Adds release notes for 21.0.0b8 describing the new Ubuntu2604 option. |
| src/aks-preview/azext_aks_preview/_params.py | Adds Ubuntu2604 into OS SKU enum lists used by argument definitions (including create/add/update surfaces). |
| src/aks-preview/azext_aks_preview/_help.py | Updates --os-sku help text to include Ubuntu2604. |
| src/aks-preview/azext_aks_preview/_consts.py | Introduces CONST_OS_SKU_UBUNTU2604 = "Ubuntu2604". |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/_params.py:316
- This change adds
Ubuntu2604tonode_os_skus_create, which makes--os-sku Ubuntu2604available onaz aks create(seearg_type=get_enum_type(node_os_skus_create)), not justaz aks nodepool add/updateas stated in the PR title/HISTORY. Becausenode_os_skus_addis derived fromnode_os_skus_create, this also affects other command surfaces that reusenode_os_skus_add(e.g.,aks machine add). Please either (a) update the PR title/HISTORY entry to reflect all impacted commands, or (b) restrict the enum change to only the intended command(s) ifaz aks createshould not accept Ubuntu2604 yet.
node_os_skus_create = [
CONST_OS_SKU_AZURELINUX,
CONST_OS_SKU_AZURELINUX3,
CONST_OS_SKU_FLATCAR,
CONST_OS_SKU_UBUNTU,
CONST_OS_SKU_CBLMARINER,
CONST_OS_SKU_MARINER,
CONST_OS_SKU_UBUNTU2204,
CONST_OS_SKU_UBUNTU2404,
CONST_OS_SKU_UBUNTU2604,
CONST_OS_SKU_AZURELINUXOSGUARD,
CONST_OS_SKU_AZURELINUX3OSGUARD,
CONST_OS_SKU_AZURECONTAINERLINUX,
]
node_os_skus_add = node_os_skus_create + [
Collaborator
|
AKS |
Member
|
/azp run |
FumingZhang
previously approved these changes
Jul 1, 2026
|
Azure Pipelines successfully started running 2 pipeline(s). |
yanzhudd
reviewed
Jul 2, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
@zachary-bailey could you rebase your feature branch onto main so the CI check passes? There’s a bug in the CI, and this is the simplest workaround. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (azdevrequired; see.azure-pipelines/templates/azdev_setup.ymlfor the install command untilazdev==0.2.11b1is on PyPI)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.