[Migrate] protected item id to target object id (CUSTOMER REPORTED BUG)#10056
Open
saifaldin14 wants to merge 48 commits into
Open
[Migrate] protected item id to target object id (CUSTOMER REPORTED BUG)#10056saifaldin14 wants to merge 48 commits into
saifaldin14 wants to merge 48 commits into
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 0f7acb7.
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @saifaldin14, |
saifaldin14
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the az migrate local start-migration command surface to use --target-object-id (instead of --protected-item-id) and propagates that rename through the extension’s parameter wiring, help text, and unit tests.
Changes:
- Renamed the start-migration CLI option from
--protected-item-idto--target-object-id(keeping--id). - Updated the runtime validation error message to reference
--target-object-id. - Updated help examples and unit test expectations to match the new flag name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/migrate/azext_migrate/_params.py |
Renames the CLI option for migrate local start-migration to --target-object-id. |
src/migrate/azext_migrate/custom.py |
Updates the missing-parameter CLIError message to reference --target-object-id. |
src/migrate/azext_migrate/_help.py |
Updates help parameter name and examples to use --target-object-id. |
src/migrate/azext_migrate/tests/latest/test_migrate_commands.py |
Updates unit tests to assert the new --target-object-id error text. |
Comment on lines
261
to
263
| 'protected_item_id', | ||
| options_list=['--protected-item-id', '--id'], | ||
| options_list=['--target-object-id', '--id'], | ||
| help='The full ARM resource ID of the protected item to migrate. ' |
| ) | ||
|
|
||
| self.assertIn("--protected-item-id parameter must be provided", | ||
| self.assertIn("--target-object-id parameter must be provided", |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Migrate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the migrate command we need to rename the protected item id parameter to target object id