docs: correct menu paths, add generated reference, fix navigation - #2372
Open
Suneha Bose (bosesuneha) wants to merge 7 commits into
Open
docs: correct menu paths, add generated reference, fix navigation#2372Suneha Bose (bosesuneha) wants to merge 7 commits into
Suneha Bose (bosesuneha) wants to merge 7 commits into
Conversation
Suneha Bose (bosesuneha)
force-pushed
the
docs/content-corrections
branch
from
August 5, 2026 23:45
755fb5b to
b09e9f7
Compare
This was referenced Aug 6, 2026
Suneha Bose (bosesuneha)
force-pushed
the
docs/content-corrections
branch
from
August 12, 2026 00:06
3cb088c to
e65f2e5
Compare
Suneha Bose (bosesuneha)
marked this pull request as ready for review
August 12, 2026 00:23
Suneha Bose (bosesuneha)
force-pushed
the
docs/content-corrections
branch
from
August 12, 2026 02:07
e65f2e5 to
47e6b1d
Compare
…ate copies
The published Development section rendered as a bare heading because
SUMMARY.md linked to ./development.md, which did not exist. mdBook's
create-missing default silently generated an empty stub instead of failing,
so this went unnoticed. Add the page and set create-missing = false.
Three pages under docs/ were stale forks of their docs/book/src/
counterparts, and docs/README.md linked only to the forks:
docs/webview-development.md missing the Custom UI Elements section
docs/package-scripts.md missing the Local VSIX Sharing section
docs/maintenance/README.md last updated 2021; missing the pinned
third-party versions section entirely
Delete them and rewrite docs/README.md as an index into book/.
The release skill instructed maintainers to mirror releasing.md into
docs/maintenance/README.md, which is why that fork stayed alive; update it
to name book/src/ as the single source of truth.
Also fixed:
- ../package.json and ../webview-ui/ links resolved outside the book
- dev-webview / build-webview are not real npm scripts (dev:webview,
build:webview)
- webpack-ui typo for webview-ui
- SUMMARY.md nav labels disagreed with the pages' own titles
- bin/ ignored; make -C docs/book build writes mdBook binaries to the repo
root because the Makefile uses $(PWD) rather than $(CURDIR)
Adds reference/ pages generated from package.json by scripts/generate-docs-reference.js, carrying a DO NOT EDIT header: commands with their menu placement, settings, and pinned versions. SUMMARY.md listed show-properties-azureportal-start-stop.md four times and inspektor-gadget.md twice, so three sidebar entries led to a page that did not match the label clicked. Collapsed to one entry each; no URLs change. features.md was a stale 2.1.0 release spotlight that linked to 2 of its 25 feature pages. Rewritten as an index. This orphans 5 classic-menu screenshots, removed in a later PR.
aks.simplifiedMenuStructure has defaulted to true since Azure#2168, grouping cluster commands under Develop & Deploy, Troubleshoot & Diagnose, and Manage Cluster. The guides still described the classic flat menu, so readers were told to look for items that are now one level down. Paths come from the generated menu reference, not from reading the UI, and are written as "Right-click your AKS cluster > Submenu > Command" so docs-check can validate them. Guides describe the default menu; the classic layout is covered once, in simplified-menu-structure.md. Also corrected: - aks-compare-cluster is on the subscription node, not the cluster node - "Managed Cluster Operations" is the classic label; the default is "Manage Cluster" - the KAITO submenu is "Deploy a LLM with KAITO", not "an LLM" - container-assist pointed at AKS: Run Container Assist (Preview), which has no menu contribution; replaced with the three real commands - inspektor-gadget claimed the command had moved to the main context menu, which described the classic layout and was backwards - "Abort Last Operation" is a webview action in ClusterPropertiesPanel.ts, not a command, so it is no longer listed as a menu operation - simplified-menu-structure.md advised keeping the default false while stating above that it was true merge-save-kubeconfig.md is left alone: those commands belong to ms-kubernetes-tools.vscode-kubernetes-tools.
Mechanical. Only the number of leading '#' changes; heading text is untouched, so every anchor still resolves. 17 pages had a broken hierarchy: 12 jumped from '#' straight to '###', and 5 had no top-level heading at all. Each file's levels were remapped to a contiguous sequence starting at 1, and where that left more than one h1 the later ones were demoted so each page has a single title. Sidebar labels come from SUMMARY.md so navigation was unaffected, but skipped levels are a problem for screen readers.
Two commands set both `category: "AKS"` and an `AKS: ` prefix in their
title, so VS Code rendered them as "AKS: AKS: Launch Kickstart Agent"
and "AKS: AKS: Configure Kickstart Cluster" in the Command Palette.
VS Code composes the palette entry as `category: title`, so the prefix
belongs in exactly one of the two. Dropped it from the titles.
No localized `package.nls.*.json` files exist and `l10n/bundle.l10n.json`
does not carry these strings, so no translations are affected. The
rendered palette text is unchanged from what the docs already describe.
`generate-docs-reference.js` already reports this class of problem
("title repeats its category"); that finding is now clear. Regenerated
`reference/commands.md` in the same commit so the generated output
cannot disagree with `package.json`.
Removed `create-gh-workflow.md`. It described the retired
`actions/starter-workflows` templates, while the live command
(`aks.draftWorkflow`) scaffolds via Draft and is documented in
`draft-integration.md`.
`README.md` re-listed all 25 feature pages by hand, a third copy after
SUMMARY.md and features.md. It had drifted: four entries pointed at the
same page under different labels, and the Container Assist sub-pages and
Copilot plugin page were missing. Replaced with pointers to the Features
index and the generated Reference.
Rebased onto main, which renamed aks.draftArgoCDDeployment to "AKS: Create Argo CD Application" in Azure#2353. Regenerated so the committed reference matches package.json; otherwise docs:reference:check would fail once Azure#2371 lands.
Suneha Bose (bosesuneha)
force-pushed
the
docs/content-corrections
branch
from
August 12, 2026 02:24
47e6b1d to
7bab4bc
Compare
Signed-off-by: Suneha Bose <123775811+bosesuneha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of 3. Stacked on #2370, so it currently shows that PR's commits too. Review the three commits listed below; they need different levels of scrutiny.
Depends on #2371 for the generator.
1. Generated reference and navigation
Adds a
Referencesection generated frompackage.jsonbyscripts/generate-docs-reference.js, carrying aDO NOT EDITheader: commands with their menu placement, settings, and pinned versions. Menu placement is not derivable by hand, with 66 commands across two menu modes nested up to four levels.SUMMARY.mdlistedshow-properties-azureportal-start-stop.mdfour times under four labels andinspektor-gadget.mdtwice, so three sidebar entries led to a page that did not match the label clicked. Collapsed to one each. No URLs change.features.mdwas a stale2.1.0release spotlight with 20 generically captioned screenshots, linking to 2 of its 25 feature pages. Rewritten as an index.2. Menu path corrections (needs the most review)
aks.simplifiedMenuStructurehas defaulted totruesince #2168, grouping cluster commands under Develop & Deploy, Troubleshoot & Diagnose, and Manage Cluster. The guides still described the classic flat menu, so readers were told to look for items that are now one level down.Paths come from the generated reference, not from reading the UI, and are written as
Right-click your AKS cluster > Submenu > Commandsodocs-checkcan validate them.Beyond the missing group level:
aks-compare-clustermanage-cluster-operationskaito-*container-assist-integrationAKS: Run Container Assist (Preview)inspektor-gadget"Abort Last Operation" was listed as a cluster operation. It is a webview action in
ClusterPropertiesPanel.ts, not a command, and there are two of them.simplified-menu-structure.mdadvised keeping the defaultfalsewhile stating above that it wastrue.merge-save-kubeconfig.mdis untouched: those commands belong toms-kubernetes-tools.vscode-kubernetes-tools, which is a separate correction.3. Heading levels (mechanical, skim it)
Only the number of leading
#changes. Heading text is untouched, so every anchor still resolves. 17 pages had a broken hierarchy: 12 jumped from#straight to###, 5 had no top-level heading.Verification
docs:check0 errors,docs:reference:checkup to date,mdbook buildclean,lychee --offline --include-fragments0 errors.Remaining warnings are tracked for PR 3: 21 undocumented commands, 14 orphaned images. Five of those orphans come from the
features.mdrewrite and are classic-menu screenshots predating the menu change, so they were stale regardless.4. Command Palette shows "AKS: AKS:" (added)
aks.kickstart.launchExperienceandaks.kickstartClusterset bothcategory: "AKS"and anAKS:prefix in theirtitle. VS Code composes the palette entry ascategory: title, so both rendered as:The prefix belongs in exactly one place; dropped it from the titles. The rendered palette text is now what the docs already claimed it was.
generate-docs-reference.jsalready flags this class of problem (title repeats its category), so the fix is verified by the generator going quiet rather than by inspection. Regeneratedreference/commands.mdin the same commit so generated output cannot disagree withpackage.json.No localized
package.nls.*.jsonfiles exist andl10n/bundle.l10n.jsondoes not carry these strings, so no translations are affected.Two related findings the generator reports were left alone as product decisions:
aks.aksKaitoGenerateYamlandaks.aksKaitoCreateCRDare both titledCreate KAITO Workspaceand both palette-visible.Storage,Best Practices,Node Health,Delete Cluster), so they appear unattributed in the global palette.5.
create-gh-workflow.mdremoved (added)The page described the retired
actions/starter-workflowstemplates. The live commandaks.draftWorkflowscaffolds via Draft and is documented indraft-integration.md. Removed fromSUMMARY.mdand the feature index.6. Rebased onto current main
The branch was based on a commit predating #2353, which renamed
aks.draftArgoCDDeploymentto AKS: Create Argo CD Application. The committed reference still carried the old name and would have faileddocs:reference:checkonce #2371 lands. Rebased and regenerated.README.mdre-listed all 25 feature pages by hand — a third copy afterSUMMARY.mdandfeatures.md, and already drifted: four entries pointed at the same page under different labels, and the Container Assist sub-pages and Copilot plugin page were missing. Replaced with pointers to the feature index and the generated reference.