Fix openPMD Meta-Data#349
Conversation
ax3l
added
bug
ax3l
force-pushed
the
fix-openPMD-metadata
branch
from
b3e4954 to
8dce959
Compare
Check created files with `openPMD-validator` to conform with the `openPMD-standard`.
ax3l
force-pushed
the
fix-openPMD-metadata
branch
from
8dce959 to
ba83cf3
Compare
| beam["positionOffset"]["ct"].resetDataset(d_fl); | ||
| beam["positionOffset"]["ct"].makeConstant(ref_part.t); |
There was a problem hiding this comment.
@cemitch99 here for positionOffset and in position, do we want to output s+delta s instead of ct + c*dt?
There was a problem hiding this comment.
Not sure I follow what the intended output is here. I understand that by "ct" you mean "ref_part.t", but what is meant by "dt"? Does this represent one or more particle values of the "t" coordinate?
In general, I would say that "s" is qualitatively different from the other variables like ct. It is an independent variable, it is associated only with the reference particle, and the other (beam particle) values are given as functions of "s".
There was a problem hiding this comment.
Thanks, ah yes I was confused for a second... So per particle, splitting the longitudinal position (for a fixed s) into ref_part.t (should we call this ref_part.ct?) and position.ct makes sense...
ax3l
force-pushed
the
fix-openPMD-metadata
branch
from
3f978de to
c07eb30
Compare
pipe arguments
ax3l
force-pushed
the
fix-openPMD-metadata
branch
from
c07eb30 to
03769f2
Compare
2 participants
Tests
Check created files with
openPMD-validatorto conform with theopenPMD-standard.Fixes
Add the
positionOffsetrecord of openPMD, which can be used for coarse particle positions or general offsets of a particle species.This refers now to the offset added by the reference particle.
Follow-up to #299