Skip to content

FieldGather.H : fix for uninitialized arrays #6254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RemiLehe merged 3 commits into from
Oct 9, 2025
Merged

FieldGather.H : fix for uninitialized arrays #6254

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9570dfb
initialized to {0._rt} all arrays concerned
grobertdautun Oct 8, 2025
415db2a
Merge branch 'BLAST-WarpX:development' into uninitialized_sz
grobertdautun Oct 8, 2025
d9d42b3
initialising everything to be sure
grobertdautun Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Source/Particles/Gather/FieldGather.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,8 @@ void doGatherShapeN ([[maybe_unused]] const amrex::ParticleReal xp,
// sx_[eb][xyz] shape factor along x for the centering of each current
// There are only two possible centerings, node or cell centered, so at most only two shape factor
// arrays will be needed.
amrex::Real sx_node[depos_order + 1];
amrex::Real sx_cell[depos_order + 1];
amrex::Real sx_node[depos_order + 1] = {0._rt};
amrex::Real sx_cell[depos_order + 1] = {0._rt};
amrex::Real sx_node_galerkin[depos_order + 1 - galerkin_interpolation] = {0._rt};
amrex::Real sx_cell_galerkin[depos_order + 1 - galerkin_interpolation] = {0._rt};

Expand Down Expand Up @@ -441,10 +441,10 @@ void doGatherShapeN ([[maybe_unused]] const amrex::ParticleReal xp,
#if defined(WARPX_DIM_3D)
// y direction
const amrex::Real y = (yp-xyzmin.y)*dinv.y;
amrex::Real sy_node[depos_order + 1];
amrex::Real sy_cell[depos_order + 1];
amrex::Real sy_node_v[depos_order + 1 - galerkin_interpolation];
amrex::Real sy_cell_v[depos_order + 1 - galerkin_interpolation];
amrex::Real sy_node[depos_order + 1] = {0._rt};
amrex::Real sy_cell[depos_order + 1] = {0._rt};
amrex::Real sy_node_v[depos_order + 1 - galerkin_interpolation] = {0._rt};
amrex::Real sy_cell_v[depos_order + 1 - galerkin_interpolation] = {0._rt};
int k_node = 0;
int k_cell = 0;
int k_node_v = 0;
Expand Down Expand Up @@ -479,10 +479,10 @@ void doGatherShapeN ([[maybe_unused]] const amrex::ParticleReal xp,
#if !defined(WARPX_DIM_RCYLINDER) && !defined(WARPX_DIM_RSPHERE)
// z direction
const amrex::Real z = (zp-xyzmin.z)*dinv.z;
amrex::Real sz_node[depos_order + 1];
amrex::Real sz_cell[depos_order + 1];
amrex::Real sz_node_v[depos_order + 1 - galerkin_interpolation];
amrex::Real sz_cell_v[depos_order + 1 - galerkin_interpolation];
amrex::Real sz_node[depos_order + 1] = {0._rt};
amrex::Real sz_cell[depos_order + 1] = {0._rt};
amrex::Real sz_node_v[depos_order + 1 - galerkin_interpolation] = {0._rt};
amrex::Real sz_cell_v[depos_order + 1 - galerkin_interpolation] = {0._rt};
int l_node = 0;
int l_cell = 0;
int l_node_v = 0;
Expand Down
Loading