Skip to content

fix share PlatformException Non-empty title expected #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodjima33 merged 3 commits into from
Jun 11, 2026
+4 −2
Merged

fix share PlatformException Non-empty title expected #7820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ef9534
fix guard empty messageText before Share.share in chat message action…
krushnarout Jun 11, 2026
7716d97
fix pass null subject instead of empty string in shareConversationLink
krushnarout Jun 11, 2026
098c236
fix move isEmpty guard before haptic; fix empty subject in app_detail…
krushnarout Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/pages/apps/app_detail/app_detail.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ class _AppDetailPageState extends State<AppDetailPage> {

await Share.share(
'https://h.omi.me/apps/${app.id}',
subject: app.name,
subject: app.name.isEmpty ? null : app.name,
sharePositionOrigin: sharePositionOrigin,
);
},
Expand Down
1 change: 1 addition & 0 deletions app/lib/pages/chat/widgets/ai_message.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,6 +1210,7 @@ class _MessageActionBarState extends State<MessageActionBar> {
_buildActionButton(
icon: FontAwesomeIcons.share,
onTap: () async {
if (widget.messageText.isEmpty) return;
HapticFeedback.lightImpact();
await Share.share(widget.messageText);
Comment on lines 1212 to 1215

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The haptic feedback fires before the isEmpty guard, so if messageText is ever empty the user feels a tap response but nothing happens — no share sheet appears and no analytics are emitted. Moving the guard before the haptic keeps the feedback tied to the action actually executing.

Suggested change
onTap: () async {
HapticFeedback.lightImpact();
if (widget.messageText.isEmpty) return;
await Share.share(widget.messageText);
onTap: () async {
if (widget.messageText.isEmpty) return;
HapticFeedback.lightImpact();
await Share.share(widget.messageText);

PlatformManager.instance.analytics.track(
Expand Down
3 changes: 2 additions & 1 deletion app/lib/pages/conversation_detail/share.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ import 'package:omi/backend/schema/conversation.dart';

void shareConversationLink(ServerConversation conversation, {Rect? sharePositionOrigin}) {
final content = 'https://h.omi.me/conversations/${conversation.id}';
Share.share(content, subject: conversation.structured.title, sharePositionOrigin: sharePositionOrigin);
final subject = conversation.structured.title;
Share.share(content, subject: subject.isEmpty ? null : subject, sharePositionOrigin: sharePositionOrigin);
}
Loading