Improve repl output window performance

CHANGELOG.md

@@ -4,6 +4,10 @@ Changes to Calva.
 
 ## [Unreleased]
 
+- Fix: [Rogue loops that print output to stdout cause Calva to hang](https://github.com/BetterThanTomorrow/calva/issues/2010)
+- Fix: [Output window becomes very slow when number of lines of content is very high](https://github.com/BetterThanTomorrow/calva/issues/804)
+- Partial Fix: [Output window becomes very slow when number of lines of content is very high](https://github.com/BetterThanTomorrow/calva/issues/942)
+
 ## [2.0.323] - 2023-01-07
 
 - Fix: [Provider completions not handling errors gracefully](https://github.com/BetterThanTomorrow/calva/issues/2006)

package.json

@@ -770,6 +770,16 @@
               "lsp"
             ]
           },
+          "calva.replOutputThrottleRate": {
+            "markdownDescription": "If the repl outputs too quickly then results will be dropped from the output window. Setting this to 0 will disable throttling.",
+            "type": "number",
+            "default": 100
+          },
+          "calva.replOutputMaxLines": {
+            "markdownDescription": "The maximum number of lines to retain in the repl output window. Having the repl output window grow too large can significantly affect performance. Setting this to 0 will disable truncating",
+            "type": "number",
+            "default": 1000
+          },
           "calva.depsEdnJackInExecutable": {
             "markdownDescription": "Which executable should Calva Jack-in use for starting a deps.edn project? The default is to let Calva choose. It will choose `clojure` if that is installed and working. Otherwise `deps.clj`, which is bundled with Calva, will be used. (This settings has no effect on Windows, where `deps.clj` will always be used.)",
             "enum": [

src/config.ts

@@ -14,6 +14,9 @@ const REPL_FILE_EXT = 'calva-repl';
 const KEYBINDINGS_ENABLED_CONFIG_KEY = 'calva.keybindingsEnabled';
 const KEYBINDINGS_ENABLED_CONTEXT_KEY = 'calva:keybindingsEnabled';
 
+const REPL_OUTPUT_THROTTLE_RATE_CONFIG_KEY = 'calva.replOutputThrottleRate';
+const REPL_OUTPUT_MAX_LINES_CONFIG_KEY = 'calva.replOutputMaxLines';
+
 type ReplSessionType = 'clj' | 'cljs';
 
 // include the 'file' and 'untitled' to the
@@ -234,6 +237,8 @@ export {
   REPL_FILE_EXT,
   KEYBINDINGS_ENABLED_CONFIG_KEY,
   KEYBINDINGS_ENABLED_CONTEXT_KEY,
+  REPL_OUTPUT_THROTTLE_RATE_CONFIG_KEY,
+  REPL_OUTPUT_MAX_LINES_CONFIG_KEY,
   documentSelector,
   ReplSessionType,
   getConfig,

src/results-output/results-doc.ts

@@ -17,6 +17,13 @@ import { formatAsLineComments, splitEditQueueForTextBatching } from './util';
 
 const RESULTS_DOC_NAME = `output.${config.REPL_FILE_EXT}`;
 
+const REPL_OUTPUT_THROTTLE_RATE = vscode.workspace
+  .getConfiguration()
+  .get<number>(config.REPL_OUTPUT_THROTTLE_RATE_CONFIG_KEY);
+const REPL_OUTPUT_MAX_LINES = vscode.workspace
+  .getConfiguration()
+  .get<number>(config.REPL_OUTPUT_MAX_LINES_CONFIG_KEY);
+
 const PROMPT_HINT = 'Use `alt+enter` to evaluate';
 
 const START_GREETINGS = [
@@ -303,10 +310,22 @@ async function writeToResultsDoc({ text, onAppended }: ResultsBufferEntry): Prom
   const insertPosition = doc.positionAt(Infinity);
   const edit = new vscode.WorkspaceEdit();
   const editText = util.stripAnsi(text);
+
+  if (REPL_OUTPUT_MAX_LINES > 0 && doc.lineCount > REPL_OUTPUT_MAX_LINES) {
+    edit.delete(
+      docUri,
+      new vscode.Range(
+        new vscode.Position(0, 0),
+        new vscode.Position(doc.lineCount - REPL_OUTPUT_MAX_LINES, 0)
+      )
+    );
+  }
+
   edit.insert(docUri, insertPosition, editText);
   if (!((await vscode.workspace.applyEdit(edit)) && (await doc.save()))) {
     return;
   }
+
   onAppended?.(
     new vscode.Location(docUri, insertPosition),
     new vscode.Location(docUri, doc.positionAt(Infinity))
@@ -331,6 +350,16 @@ export interface OnAppendedCallback {
 
 let resultsBuffer: ResultsBuffer = [];
 
+type BufferThrottleState = {
+  count: number;
+  dropped: number;
+  timeout?: NodeJS.Timeout;
+};
+const throttleState: BufferThrottleState = {
+  count: 0,
+  dropped: 0,
+};
+
 async function writeNextOutputBatch() {
   if (!resultsBuffer[0]) {
     return;
@@ -366,6 +395,30 @@ async function flushOutput() {
 
 /* If something must be done after a particular edit, use the onAppended callback. */
 export function append(text: string, onAppended?: OnAppendedCallback): void {
+  if (REPL_OUTPUT_THROTTLE_RATE > 0) {
+    throttleState.count++;
+
+    if (!throttleState.timeout) {
+      throttleState.timeout = setTimeout(() => {
+        if (throttleState.dropped > 0) {
+          resultsBuffer.push({
+            text: `;; Dropped ${throttleState.dropped} items from output due to throttling\n`,
+          });
+          void flushOutput();
+        }
+
+        throttleState.timeout = undefined;
+        throttleState.count = 0;
+        throttleState.dropped = 0;
+      }, 500);
+    }
+
+    if (throttleState.count > REPL_OUTPUT_THROTTLE_RATE) {
+      throttleState.dropped++;
+      return;
+    }
+  }
+
   resultsBuffer.push({ text, onAppended });
   void flushOutput();
 }

src/results-output/util.ts

@@ -24,7 +24,7 @@ function splitEditQueueForTextBatching(
   const nextBatch = takeWhile(editQueue, (value, index) => {
     return index < maxBatchSize && !value.onAppended;
   }).map((x) => x.text);
-  const remainingEditQueue = [...editQueue].slice(nextBatch.length);
+  const remainingEditQueue = editQueue.slice(nextBatch.length);
   return [nextBatch, remainingEditQueue];
 }