Fix/extract function selection args#3174
Open
jramosg wants to merge 4 commits intoBetterThanTomorrow:devfrom
Open
Fix/extract function selection args#3174jramosg wants to merge 4 commits intoBetterThanTomorrow:devfrom
jramosg wants to merge 4 commits intoBetterThanTomorrow:devfrom
Conversation
Ensure that the 'extract-function' command appends selection end coordinates to the parameters. This prevents IndexOutOfBoundsException when the command is called with insufficient arguments, allowing it to work correctly regardless of whether a region is selected.
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed?
Ensure that the 'extract-function' command appends selection end
coordinates to the parameters. This prevents IndexOutOfBoundsException
when the command is called.
Fixes #
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).