Skip to content

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. #155

Closed

Description

@jaseel0

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @src/components/layout/Navbar.tsx at line 109, The mobile GitHub CTA
currently nests a native inside an because Button (from
src/components/ui/Button) defaults asChild=false; update the CTA so Button
receives the prop asChild to render the anchor element instead of a nested
button—i.e., change the Button usage in the mobile CTA to <Button asChild ...>
(preserving existing className and props) so the anchor becomes the rendered
element and the invalid nesting is removed.

Originally posted by @jaseel0 in #154 (comment)

Activity

  1. added
    area: frontendChanges specifically for the UI/Tailwind components.
    documentationImprovements or additions to documentation
    typescriptType definition fixes, interfaces, or TS configuration.
    on May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area: frontendChanges specifically for the UI/Tailwind components.documentationImprovements or additions to documentationtypescriptType definition fixes, interfaces, or TS configuration.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions