fix(macos): preserve app icons during entrypoint repair - #1696
Open
shaoxianbilly wants to merge 1 commit into
Open
fix(macos): preserve app icons during entrypoint repair#1696shaoxianbilly wants to merge 1 commit into
shaoxianbilly wants to merge 1 commit into
Conversation
Owner
|
复审确认修复方向合理:当前主线的修复入口仍引用不存在的 PNG,而 release 包实际提供 |
Owner
|
修复方向仍成立:修复入口应复制并引用 bundle 中实际存在的 ICNS,而不是不存在的 PNG。请 rebase 当前 main,避免带入旧安装器命名断言,并重新运行 macOS installer 定向测试和三平台构建;当前冲突状态不合并。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.icnsicon.icnsfrom the current app bundle instead of looking for a missing PNG sidecarCFBundleIconFileactually existsRoot cause
The release DMG is packaged correctly with
codex-plus-plus.icns, but the in-app entrypoint repair path rewritesInfo.plisttocodex-plus-plus.pngand looks for a PNG beside the executable. That file is absent in the DMG apps, so Finder/Spotlight display a generic icon after repair.Verification
cargo fmt --all -- --checkcargo test -p codex-plus-core --test installers macos_bundle_metadata_contains_silent_and_manager_apps -- --exactgit diff --checkpassesExisting unrelated test failures
The full
installerstest binary currently has two pre-existing macOS companion-path assertion failures involvingCodexPlusPlusManagervscodex-plus-plus-manager; this PR does not touch that path logic.