fix: sync manager user script runtime status - #1723
Merged
BigPizzaV3 merged 1 commit intoAug 18, 2026
Merged
Conversation
Rat0323
marked this pull request as ready for review
July 31, 2026 07:34
Owner
|
维护者审查:该 PR 的状态探测依赖 target 选择修复,不能按当前分支独立合并。
#1730 已新增 Manager 排除和 Codex 主页面优先选择,说明这个场景确实存在。建议先处理 #1730 中的 target picker(可拆成独立小 PR),再将本 PR rebase 到该实现;同时补一个 targets 同时包含 Manager 和 Codex 主页面的测试,断言 probe 选择 Codex 主页面。 另外 #1730 当前还有脚本 cleanup 生命周期问题,因此更稳妥的顺序是先拆出/合并纯 target picker 修复,再合并本 PR,而不是让本 PR 依赖整套热重载功能。 |
Rat0323
force-pushed
the
agent/manager-user-script-runtime-status
branch
from
August 12, 2026 07:51
0570cb0 to
56aeb91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
window.__codexPlusUserScripts.scriptsWhy
PR #1611 fixed runtime status reporting in the Codex-embedded user-script panel, but the standalone Codex++ Manager still called
UserScriptManager::inventory()without renderer state. As a result, scripts that were actively running appeared asnot_loadedin Script Market > Local scripts.The new probe opens a short-lived, read-only CDP connection and reads the existing renderer registry directly. It does not reinject scripts and does not call the renderer bridge from inside CDP.
Validation
npm test(36 passed)npm run checknpm run vite:buildcargo check -p codex-plus-managercargo test -p codex-plus-core runtime_status_tests(2 passed)cargo test -p codex-plus-core --test upstream_theme_assets(2 passed after LF normalization)cargo test --workspace: all suites passed through the launcher tests; the pre-normalization run then reproduced the known Windows byte-exact EOL failures, which are covered by the included.gitattributesfix and the focused rerun aboveFollow-up to #1611.