You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm beginning to suspect (though they never actually say it anywhere, that I can find) that the "Always import new translations..." option is an Enterprise-only feature. So, I take it back (again)... it probably is necessary to do things this way, after all.
Update
Turns out this may not be necessary at all, as there may be a simpler solution.
According to Crowdin's docs, their GitHub integration should now have a checkbox for "Always import new translations from the repository". It's turned off by default, but turning it on might set all this up for us.
This PR grew out of discussion in #973, regarding feeding translations back to Crowdin when they're updated locally. The code here is an attempt to make that work. It is untested, because it cannot be tested until some prerequisites are met.
This PR will not work and SHOULD NOT BE MERGED unless the repository is first configured with the necessary Crowdin credentials so that the action has access to upload into the Crowdin project.
Obtaining that access requires someone with admin access to both the Crowdin and Github sides of the project to do the following:
CROWDIN_PERSONAL_TOKEN should store the generated token
Only after that is done, will it be possible to TEST this PR. Because it currently contains the setting dryrun_action: true, it still won't do anything that would affect the Crowdin project.
If things look sane, then we can remove that line and test it for real.
Oh, right: Because Github sensibly won't run newly-created actions from PRs, this will have to be merged before any testing can be done. So, I guess, once the secrets are created, it would probably make sense to merge this with the dryrun_action: true line still in it. That'll let us see if things look right, at which point a subsequent commit/PR can remove the dryrun line.
I added workflow_dispatch to the action as a trigger method, so that it will be possible for project admins to manually run the workflow from the Actions tab of the repo. That'll probably be useful at least for testing, because it's configured to only automatically run when a commit changes files in the core/src/com/biglybt/internat/ directory. (So, very infrequently.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update 2
I'm beginning to suspect (though they never actually say it anywhere, that I can find) that the "Always import new translations..." option is an Enterprise-only feature. So, I take it back (again)... it probably is necessary to do things this way, after all.
Update
Turns out this may not be necessary at all, as there may be a simpler solution.According to Crowdin's docs, their GitHub integration should now have a checkbox for "Always import new translations from the repository". It's turned off by default, but turning it on might set all this up for us.
@parg, @TuxPaper, worth a look?
cc: @lislei
↑ (It's down here at the bottom)Original summary
This PR grew out of discussion in #973, regarding feeding translations back to Crowdin when they're updated locally. The code here is an attempt to make that work. It is untested, because it cannot be tested until some prerequisites are met.
This PR will not work and SHOULD NOT BE MERGED unless the repository is first configured with the necessary Crowdin credentials so that the action has access to upload into the Crowdin project.
Obtaining that access requires someone with admin access to both the Crowdin and Github sides of the project to do the following:
CROWDIN_PROJECT_IDshould store the project IDCROWDIN_PERSONAL_TOKENshould store the generated tokenOnly after that is done, will it be possible to TEST this PR. Because it currently contains the setting
dryrun_action: true, it still won't do anything that would affect the Crowdin project.If things look sane, then we can remove that line and test it for real.
cc: @parg @TuxPaper