Skip to content

Improved worksharing across threads for find_overlaps_groups. - #65

Merged
jkanche merged 2 commits into
masterfrom
worksharing
Sep 16, 2025
Merged

jkanche merged 2 commits into
masterfrom
worksharing

Conversation

@LTLA

@LTLA LTLA commented Sep 12, 2025

Copy link
Copy Markdown
Member

The idea is to ensure that all threads are occupied, even when the groups are of different sizes. This is done with some more fine-grained parallelization during both index building and overlap identification.

LTLA and others added 2 commits September 12, 2025 14:15
The idea is to ensure that all threads are occupied, even when the groups are
of different sizes. This is done with some more fine-grained parallelization
during both index building and overlap identification.
@codecov

codecov Bot commented Sep 12, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.04%. Comparing base (b0d06bb) to head (e580aab).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files           4        4           
  Lines         877      877           
  Branches      166      166           
=======================================
  Hits          588      588           
  Misses        213      213           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkanche

jkanche commented Sep 16, 2025 •

Copy link
Copy Markdown
Member

seems like it slows down the runtimes. not sure what might be causing this, I will investigate this later

@LTLA

LTLA commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

Well the previous code didn't parallelize at all if there was only a single group. So this should actually make use of multiple threads and be faster in that scenario.

@jkanche
jkanche merged commit 3158442 into master Sep 16, 2025
11 checks passed
@jkanche
jkanche deleted the worksharing branch September 16, 2025 06:47
@jkanche

jkanche commented Sep 16, 2025

Copy link
Copy Markdown
Member

gotcha, arigatou guzaimasu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants