feat(tx-manifest): add deterministic action review - #11
Open
lukachi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge train
PR 2 of 9. This PR targets
feature/tx-manifest-parser(PR #10), notmaster.The next PR will target this branch and add the concrete smplx WASM adapter plus internal transaction construction/finalization.
Scope
This slice intentionally supports the canonical p2pk path and one mapped compile parameter type (
pubkey). The compiler and chain reader are injected ports; this PR does not connect to a WASM module or endpoint.Excluded from this PR:
Verification
bun test packages/tx-manifest— 36 pass, 0 failbun run typecheck:packagesbun run typecheckbunx oxlint packages/tx-manifest— 0 findingsbunx oxfmt packages/tx-manifest --checkbun run lint— passes with pre-existing repository warningsThe normal pre-commit hook also passed i18n, lint, and typecheck. Its repository-wide format step failed only because it scans pre-existing unrelated
.claude/settings.local.jsonand untrackedsmplx/files, so the reviewed commit was created with--no-verify.