Add formatting logic to the extension - #8
Open
ikripaka wants to merge 5 commits into
Open
Conversation
ikripaka
force-pushed
the
feat/formatter
branch
2 times, most recently
from
August 26, 2026 15:08
9f8ed1c to
97a9cdd
Compare
ikripaka
marked this pull request as ready for review
August 26, 2026 15:26
* add promises for updating to reduce repeated actions * add constants for binary discovery * add update state hook in activation
ikripaka
force-pushed
the
feat/formatter
branch
from
August 31, 2026 15:38
0400cb9 to
c4b0da9
Compare
gerau
requested changes
Sep 7, 2026
| ); | ||
| }); | ||
|
|
||
| void test("rejects unsupported binaries without making a request", async () => { |
Collaborator
There was a problem hiding this comment.
this test is failing
we should probably figure out why tests are not running in CI...
Collaborator
Author
There was a problem hiding this comment.
I removed that test. By now, all our binaries are supported and statically verified because of strict types.
* all our binaries are supported
Collaborator
|
ACK 9ff7d71; tested locally |
Collaborator
|
Maybe better to wait for the simplex fmt and rely on that for the formatting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr continues the formatter implementation in a simplified way
Closes #4