Real round-trip tests (PLAN §K1) + unknown-field warnings + Part 4 plan#5
Conversation
…AN §K1); warn before dropping unknown fields - Fixture copies of both shooter arenas; loadWorld -> saveWorld -> parse -> structural deep-compare with dotted-path diffs. Both pass: the saver is semantically lossless on real worlds, terrain + splat layers included. - testPrefabFileRoundTrip pins the engine-side serializePrefab fix (schemaVersion + bounds used to be dropped). - openWorld posts a status-bar warning naming unknown fields BEFORE the user can save them away; testUnknownFieldDetection guards against false positives. - PLAN.md: Part 4 added — any world, any game: audit + phased plan. Requires engine fix/world-file-trust (Bloom-Engine/engine#104). 129 self-tests pass. Claude-Session: https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Phase 1 of PLAN.md Part 4 (any world, any game — added in this PR):
loadWorld→saveWorld→ parse → structural deep-compare with dotted-path diff reporting. Both pass — the saver is semantically lossless on real worlds, terrain + splat layers included. The syntheticJSON.stringifytest (a green tick over the exact hole) is deleted.serializePrefabdroppedschemaVersion+bounds).openWorldposts a status-bar warning naming fields the schema-explicit saver would drop, BEFORE the user can save; the engine logs each at load. Extension points that do round-trip:metadata/userData/tags.instantiateWorldhas zero game consumers) + phased plan P1–P5.Depends on Bloom-Engine/engine#104 — merge that first or
main --testwon't compile (importslistUnknownWorldFields).129 self-tests pass.
https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K