Skip to content

Real round-trip tests (PLAN §K1) + unknown-field warnings + Part 4 plan#5

Merged
proggeramlug merged 1 commit into
mainfrom
feat/world-file-trust
Jul 17, 2026
Merged

Real round-trip tests (PLAN §K1) + unknown-field warnings + Part 4 plan#5
proggeramlug merged 1 commit into
mainfrom
feat/world-file-trust

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Phase 1 of PLAN.md Part 4 (any world, any game — added in this PR):

  • §K1 done for real: fixture copies of both shooter arenas; loadWorldsaveWorld → parse → structural deep-compare with dotted-path diff reporting. Both pass — the saver is semantically lossless on real worlds, terrain + splat layers included. The synthetic JSON.stringify test (a green tick over the exact hole) is deleted.
  • Prefab round-trip pinned by test — the engine-side fix is World-format trust + generalization: lossless round-trips, unknown-field warnings, applyWorldEnvironment, world-format.md, world-viewer example engine#104 (serializePrefab dropped schemaVersion + bounds).
  • Unknown-field policy: openWorld posts a status-bar warning naming fields the schema-explicit saver would drop, BEFORE the user can save; the engine logs each at load. Extension points that do round-trip: metadata/userData/tags.
  • PLAN.md Part 4: full any-game audit (soft-coupling inventory, ecosystem reality: shooter is the format's only consumer, instantiateWorld has zero game consumers) + phased plan P1–P5.

Depends on Bloom-Engine/engine#104 — merge that first or main --test won't compile (imports listUnknownWorldFields).

129 self-tests pass.

https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K

…AN §K1); warn before dropping unknown fields

- Fixture copies of both shooter arenas; loadWorld -> saveWorld -> parse ->
  structural deep-compare with dotted-path diffs. Both pass: the saver is
  semantically lossless on real worlds, terrain + splat layers included.
- testPrefabFileRoundTrip pins the engine-side serializePrefab fix
  (schemaVersion + bounds used to be dropped).
- openWorld posts a status-bar warning naming unknown fields BEFORE the
  user can save them away; testUnknownFieldDetection guards against
  false positives.
- PLAN.md: Part 4 added — any world, any game: audit + phased plan.

Requires engine fix/world-file-trust (Bloom-Engine/engine#104).
129 self-tests pass.

Claude-Session: https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proggeramlug, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 808d79b1-4b5d-401c-9743-9d37cdb77b9f

📥 Commits

Reviewing files that changed from the base of the PR and between 3ef86bb and 9539243.

📒 Files selected for processing (6)
  • .gitignore
  • PLAN.md
  • src/io/world-io.ts
  • src/tests/fixtures/arena_01.world.json
  • src/tests/fixtures/arena_02.world.json
  • src/tests/self-tests.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/world-file-trust

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit a28f49a into main Jul 17, 2026
1 check passed
@proggeramlug
proggeramlug deleted the feat/world-file-trust branch July 17, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant