Skip to content

SSR ships off — it was the sparkles (indoor blizzard, bisect-proven)#35

Merged
proggeramlug merged 1 commit into
mainfrom
fix/ssr-off-indoor-blizzard
Jul 16, 2026
Merged

SSR ships off — it was the sparkles (indoor blizzard, bisect-proven)#35
proggeramlug merged 1 commit into
mainfrom
fix/ssr-off-indoor-blizzard

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

The sparkle report closed with evidence: white firefly texels blanketing house interiors — survives SSGI/SSAO/shadows off, vanishes with SSR off. Captures: tools/.testout/bliz-on.png vs bliz-fixed.png.

Pure quality win, no tradeoff: water uses the planar probe, SSR was measured invisible outdoors (July audit: 'no receivers'), and interiors only got the blizzard from it. Settings row stays for A/B; engine EN-061 carries the real SSR firefly fix and the re-enable criterion. (+0.2 ms back, incidentally.)

The user's sparkle report, run to ground with the f12-live bisect:
white render-texel speckles blanketing every interior surface of the
house, worst on the ceiling. Present with SSGI off, SSAO off and
SHADOWS off; gone the instant SSR is off. The march on rough interior
concrete hits bright window/sky content through the Hi-Z pyramid;
single-texel hits become fireflies against the dim interior, widened
into blocks by the TSR upscale.

Turning SSR off here is a pure quality WIN, not a tradeoff: this
game's water reflections are the planar probe (separate system), and
the July audit measured SSR invisible outdoors ('no receivers in this
scene'). Interiors are the only place it showed, and what it showed
was the blizzard. The settings row stays for A/B; engine EN-061
carries the real SSR fix (roughness cutoff, firefly clamp, Hi-Z hit
validation) and the re-enable criterion.

Verified: INDOORCAM+AITEST captures - blizzard on ssr:1, clean
interior on ssr:0 via settings alone (tools/.testout/bliz-on.png vs
bliz-fixed.png); title boot smoke clean.
@proggeramlug
proggeramlug merged commit 5e73fd0 into main Jul 16, 2026
@proggeramlug
proggeramlug deleted the fix/ssr-off-indoor-blizzard branch July 16, 2026 18:17
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proggeramlug, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d9a2743-5ba9-4906-876b-f6dfdbff9d2e

📥 Commits

Reviewing files that changed from the base of the PR and between 79c3377 and cf04de5.

📒 Files selected for processing (1)
  • src/settings.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ssr-off-indoor-blizzard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant