Skip to content

fix: adjust overflow clip margin to line height - #7233

Closed
GZolla wants to merge 2 commits into
mainfrom
gzolla/update-clip-margin
Closed

fix: adjust overflow clip margin to line height#7233
GZolla wants to merge 2 commits into
mainfrom
gzolla/update-clip-margin

Fix test

21a3ba2
Select commit
Loading
Failed to load commit list.
D2L Jira / Find Associated Jira Tickets succeeded Jul 17, 2026 in 0s

Found at least one Jira ticket: PHNX-4815

Found at least one Jira ticket: PHNX-4815

Details

We looked for tickets in 2 places.


We did not find a ticket in the Pull Request title,

fix: adjust overflow clip margin to line height


We found ticket PHNX-4815 in Pull Request body,

PHNX-4815

From the commit history it seems that the clip margin was added to support Thai, the problem is that it's set to a fixed value.

The set value starts having issues as with smaller line-heights(relative to it's font-size) it shows part of the next line this sets a css variable so that margin adapts to the line-height.

Not 100% on this but from testing, it seems that (line-height - font-size) / 2 is the ideal value