Use overflowEllipsisDeclarations when lines=1 - #7293
Found at least one Jira ticket: PHNX-4815
Found at least one Jira ticket: PHNX-4815
Details
We looked for tickets in 2 places.
We did not find a ticket in the Pull Request title,
Use overflowEllipsisDeclarations when lines=1
We found ticket PHNX-4815 in Pull Request body,
In #7233 we adjusted the overflow clip margin to roughly follow the line-height to fix an issue with subsequent lines of text partially showing at the bottom of the clipped area. However, this only happens in Windows at mobile device widths (when we shrink the font-size and line-height) and when using
line-clampstyles. This is unlikely to occur in real-world usage already, but this PR changesline=1usages ofgetOverflowDeclarationsto always useoverflowEllipsisDeclarationsinstead ofline-clampwhich prevents this issue even further in the majority of uses.If it later becomes a problem in production we can try some other changes like adjusting the font-face styles in Windows etc.