Skip to content

Use overflowEllipsisDeclarations when lines=1 - #7293

Open
bearfriend wants to merge 3 commits into
mainfrom
dgleckler/overflow-one-line
Open

Use overflowEllipsisDeclarations when lines=1#7293
bearfriend wants to merge 3 commits into
mainfrom
dgleckler/overflow-one-line

tests

3ec2de5
Select commit
Loading
Failed to load commit list.
D2L Jira / Find Associated Jira Tickets succeeded Jul 30, 2026 in 0s

Found at least one Jira ticket: PHNX-4815

Found at least one Jira ticket: PHNX-4815

Details

We looked for tickets in 2 places.


We did not find a ticket in the Pull Request title,

Use overflowEllipsisDeclarations when lines=1


We found ticket PHNX-4815 in Pull Request body,

PHNX-4815

In #7233 we adjusted the overflow clip margin to roughly follow the line-height to fix an issue with subsequent lines of text partially showing at the bottom of the clipped area. However, this only happens in Windows at mobile device widths (when we shrink the font-size and line-height) and when using line-clamp styles. This is unlikely to occur in real-world usage already, but this PR changes line=1 usages of getOverflowDeclarations to always use overflowEllipsisDeclarations instead of line-clamp which prevents this issue even further in the majority of uses.

If it later becomes a problem in production we can try some other changes like adjusting the font-face styles in Windows etc.