Skip to content

feat: GAUD-10313 - Setup drag cursors for Safari #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svanherk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: GAUD-10313 - Setup drag cursors for Safari #7424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion components/page/page-divider-internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import '../colors/colors.js';
import '../icons/icon-custom.js';
import { css, html, LitElement, nothing } from 'lit';
import { classMap } from 'lit/directives/class-map.js';
import { FocusMixin } from '../../mixins/focus/focus-mixin.js';
import { formatPercent } from '@brightspace-ui/intl';
import { ifDefined } from 'lit/directives/if-defined.js';
Expand Down Expand Up @@ -116,6 +117,14 @@ class PageDivider extends FocusMixin(PropertyRequiredMixin(LitElement)) {
.divider:focus-within {
background-color: var(--d2l-color-celestine);
}
:host([panel-position="start"]) .divider.collapsed,
:host([panel-position="end"]) .divider.maxed {
cursor: var(--d2l-cursor-resize-inline-end, e-resize);
}
:host([panel-position="start"]) .divider.maxed,
:host([panel-position="end"]) .divider.collapsed {
cursor: var(--d2l-cursor-resize-inline-start, w-resize);
}

.slider {
inset-inline-start: -${DIVIDER_HANDLE_SIZE / 2 - DIVIDER_WIDTH / 2}px;
Expand Down Expand Up @@ -189,6 +198,12 @@ class PageDivider extends FocusMixin(PropertyRequiredMixin(LitElement)) {
height: ${DIVIDER_WIDTH}px;
width: 100%;
}
:host([panel-type="drawer"]) .divider.collapsed {
cursor: n-resize;
}
:host([panel-type="drawer"]) .divider.maxed {
cursor: s-resize;
}

:host([panel-type="drawer"]) .slider {
inset-inline-end: 18px;
Expand All @@ -215,14 +230,19 @@ class PageDivider extends FocusMixin(PropertyRequiredMixin(LitElement)) {
}

render() {
const dividerClasses = {
divider: true,
collapsed: this.currentSize <= this.collapsedSize,
maxed: this.currentSize === this.maxSize
};
const { showStartArrow, showEndArrow } = this.#getArrowVisibility();
let ariaValues = {};
if (this.maxSize > 0) {
ariaValues = { max: this.maxSize, min: 0, now: this.currentSize, text: formatPercent(this.currentSize / this.maxSize, { maximumFractionDigits: 0 }) };
}

return html`
<div class="divider" @click="${this.#handleClick}" @pointerdown="${this.#handlePointerDown}">
<div class="${classMap(dividerClasses)}" @click="${this.#handleClick}" @pointerdown="${this.#handlePointerDown}">
${this.panelType === 'panel' ? html`
<div class="divider-arrow start" data-position="start" ?hidden="${!showStartArrow}">
<d2l-icon-custom size="tier1">${ICON_ARROW_COLLAPSE_LEFT}</d2l-icon-custom>
Expand Down