Skip to content

fix: inject environment objects into settings sheet - #395

Open
Amadeus1P048596 wants to merge 1 commit into
BugenZhao:mainfrom
Amadeus1P048596:fix/macos-settings-environment-objects
Open

fix: inject environment objects into settings sheet#395
Amadeus1P048596 wants to merge 1 commit into
BugenZhao:mainfrom
Amadeus1P048596:fix/macos-settings-environment-objects

Conversation

@Amadeus1P048596

Copy link
Copy Markdown

Summary

  • explicitly pass PaywallModel, TextSelectionModel, and ViewingImageModel to the settings sheet
  • prevent missing @EnvironmentObject assertions when opening Settings and Topic Details Style on Mac (Designed for iPad)

Context

A crash report from MNGA 2.3 (123) shows EnvironmentObject.error() while SwiftUI is constructing a Form. The settings sheet is presented before the global environment-object modifiers, and sheets have previously required explicit injection on Apple silicon Macs.

Testing

  • built the My Mac (Designed for iPad) target with Xcode 26.6 and CODE_SIGNING_ALLOWED=NO
  • built and launched the iPad (A16) simulator target on iOS 26.5
  • navigated through Settings to Topic Details Style with AXe and confirmed both forms render without a crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant