Skip to content

do not use raw url in srcset #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JLarky wants to merge 2 commits into
base: main
Choose a base branch
from
Open

do not use raw url in srcset #3448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb00693
do not use raw url in srcset
JLarky Jul 26, 2024
82473d4
update per samijaber's suggestion
JLarky Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/sdks/src/blocks/image/image.helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export function getSrcSet(url: string): string {
const widthInSrc = Number(url.split('?width=')[1]);
if (!isNaN(widthInSrc)) {
srcUrl = `${srcUrl} ${widthInSrc}w`;
} else {
srcUrl = `${srcUrl} 9999w`; // #3448 every srcset element has to have "w" or "x", otherwise browsers might ignore srcset
}

return sizes
Expand Down