Skip to content

fix[widgets][carousel]: ENG-12409 prevent dom-prop warnings and hide the empty arrows #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
floating-dynamo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix[widgets][carousel]: ENG-12409 prevent dom-prop warnings and hide the empty arrows #4550

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4550e88
fix[widgets][carousel]: stop forwarding slick props to arrow dom
floating-dynamo May 5, 2026
f3dd3d6
fix[widgets][carousel]: hide arrows when both buttons are empty
floating-dynamo May 5, 2026
91d9945
Update the version in package.json
floating-dynamo May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions packages/widgets/src/components/Carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ import Slider, { ResponsiveObject, Settings } from 'react-slick';

type BuilderBlockType = BuilderElement;

const CarouselArrow = ({
currentSlide,
slideCount,
children,
...rest
}: React.HTMLAttributes<HTMLDivElement> & {
currentSlide?: number;
slideCount?: number;
}) => <div {...rest}>{children}</div>;

interface CarouselProps {
slides: Array<
React.ReactNode | { content: BuilderBlockType[] } /* BuilderBlock <- export this type */
Expand Down Expand Up @@ -106,26 +116,31 @@ export class CarouselComponent extends React.Component<CarouselProps> {
focusOnSelect={this.props.focusOnSelect}
// TODO: on change emit event on element?
// renderBottomCenterControls={this.props.hideDots ? () => null : undefined}

arrows={
!!(
(this.props.prevButton && this.props.prevButton.length) ||
(this.props.nextButton && this.props.nextButton.length)
)
}
// OOF!!
nextArrow={
<div>
<CarouselArrow>
<BuilderBlocks
parentElementId={this.props.builderBlock.id}
dataPath="component.options.prevButton"
blocks={this.props.prevButton}
/>
</div>
</CarouselArrow>
}
// OOF!!
prevArrow={
<div>
<CarouselArrow>
<BuilderBlocks
parentElementId={this.props.builderBlock.id}
dataPath="component.options.nextButton"
blocks={this.props.nextButton}
/>
</div>
</CarouselArrow>
}
{...this.props.slickProps}
>
Expand Down
Loading