FW: resolve error reporting for NMEA0183 channels to avoid stalling event-loop - #124
Open
brian-r-calder wants to merge 4 commits into
Open
FW: resolve error reporting for NMEA0183 channels to avoid stalling event-loop#124brian-r-calder wants to merge 4 commits into
brian-r-calder wants to merge 4 commits into
Conversation
…change once per channel.
brian-r-calder
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the error reporting for problems on the NMEA0183 input channels such that it only reports the aggregate errors that can appear on the serial input once every five seconds, rather than for each character (which can suck up enough processing time to stall the event loop). More details are in issue #100, which this PR will close.
In addition, this code modifies the RX inversion process so that it is only reported once per attempt (rather than for each character of any on-going message when it's first detected as being a problem).
This steps the logger version for NMEA0183 to 1.1.0.