fix(device): bound descriptor scanner lengths - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
This is a focused follow-up to the post-merge review of
3d1924607e9bfe9cfebfa9d07ad3944dc4980225. That review found that both scanner loops trusted the next descriptor's declared length before checking the three-byte header minimum and remaining buffer length. Zero-length descriptors could fail to advance, while oversized lengths could underflow the remaining-byte accounting. The new scanner-level cases reproduce those inputs and the production guards returnUVC_ERROR_INVALID_DEVICEbefore parser dispatch.How to verify
cmake -S . -B build/postcommit-gate -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_BUILD_TARGET=Static -DBUILD_SHARED_LIBS=OFF -DBUILD_EXAMPLE=OFF -DBUILD_TEST=OFF -DBUILD_TESTING=ONctest --test-dir build/postcommit-gate --output-on-failureRisks
The change is limited to malformed descriptor-length validation in the two existing iterator loops. Valid descriptors and parser behavior are unchanged; no USB hardware is required for these tests.