Resolves Issue #1735 and #1736, Preventing UUID changes on update requests#1822
Open
afoote-mitre wants to merge 1 commit into
Open
Resolves Issue #1735 and #1736, Preventing UUID changes on update requests#1822afoote-mitre wants to merge 1 commit into
afoote-mitre wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1735 and #1736
Summary
UUID changes were technically allowed by the update user and org function calls. These changes allow for UUIDs to still be passed into the request if they match the existing values, while preventing attempts to update existing UUID values.
Important Changes
src/controller/registry-user.controller/registry-user.controller.jssrc/controller/registry-org.controller/registry-org.controller.jsTesting
Steps to manually test updated functionality, if possible
npm run test:integrationand ensure all tests passnpm run test:unit-testsand ensure all tests pass