Skip to content

fix(connector): use public strip_trailing_semicolon in dry_run paths #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goldmedal merged 1 commit into from
Jul 20, 2026
Merged

fix(connector): use public strip_trailing_semicolon in dry_run paths #2550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/wren/src/wren/connector/datafusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def dry_run(self, sql: str) -> None:
# break the LIMIT subquery wrap (``SELECT 1;`` is a multi-statement batch
# the planner rejects). Strip only the terminating run so ';' inside
# string literals stays intact — same helper already used by ``query``.
self.ctx.dry_run(_strip_trailing_semicolon(sql))
self.ctx.dry_run(strip_trailing_semicolon(sql))

def close(self) -> None:
pass
Expand Down
2 changes: 1 addition & 1 deletion core/wren/src/wren/connector/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def query(self, sql: str, limit: int | None = None) -> pa.Table:
def dry_run(self, sql: str) -> None:
# ``describe`` still fails when the statement is terminated with ``;``
# (ProgrammingError: unexpected ';'). Strip only the trailing run.
cleaned = _strip_trailing_semicolon(sql)
cleaned = strip_trailing_semicolon(sql)
try:
with self.connection.cursor() as cursor:
cursor.describe(cleaned)
Expand Down
Loading