Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/wren/src/wren/memory/seed_queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,14 @@ def _relationship_seed(rel: dict, model_layers: dict[str, str]) -> dict | None:
# "condition": null in the manifest) does not slip a None past `.get()`'s
# default and crash `len(None)` / `None.strip()`. Mirrors the defensive
# `rel.get("condition") or ""` in `_relationship_key_columns`.
models = rel.get("models") or []
models = rel.get("models")
if models is None:
models = []
if not isinstance(models, list):
raise ValueError(
f"relationship {rel.get('name')!r}: 'models' must be a list, "
f"got {type(models).__name__}"
)
condition = (rel.get("condition") or "").strip()

if len(models) < 2 or not condition:
Expand Down
26 changes: 26 additions & 0 deletions core/wren/tests/unit/test_seed_queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -814,3 +814,29 @@ def test_skips_non_dict_columns():
sqls = [p["sql"] for p in pairs]
assert "SELECT * FROM orders LIMIT 100" in sqls
assert "SELECT SUM(amount) FROM orders" in sqls


@pytest.mark.unit
class TestRelationshipSeedModelsType:
def test_string_models_raises(self):
manifest = {
"models": [_model("orders", "id", [_col("id", "int")])],
"relationships": [
{
"name": "bad",
"models": "orders",
"condition": "a.id = b.id",
}
],
}
with pytest.raises(ValueError, match="models"):
generate_seed_queries(manifest)

def test_dict_models_raises(self):
manifest = {
"relationships": [
{"name": "bad", "models": {"a": 1}, "condition": "x = y"}
]
}
with pytest.raises(ValueError, match="models"):
generate_seed_queries(manifest)
Loading