fix(context): filter non-dict items in load_relationships - #2613
Conversation
Loader annotates list[dict] but only checked the outer YAML object. Consumers (validate_project, build_manifest, MCP) should not re-filter.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Walkthrough
ChangesRelationship YAML validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
load_relationshipsnow returns only mapping items so itslist[dict]contract matches loaders that already filter (e.g. models/views).Motivation
Maintainer note on closed #2547: the leak is in the loader (
context.py), not MCP consumers. #2608 covers describe_model container-type; this is the missing item filter.Test plan
test_load_relationships_skips_non_dict_itemstest_load_relationships_non_list_relationships_keySummary by CodeRabbit
Bug Fixes
Tests