fix(mcp): harden list_cubes member arrays - #2617
Open
Bartok9 wants to merge 2 commits into
Open
Conversation
list_cubes assumed cube members were always lists of dicts. Skip non-dict cubes and member rows so malformed cube YAML cannot crash MCP.
Contributor
Walkthrough
ChangesCube enumeration robustness
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failure does this repair?
MCP
list_cubesraisedAttributeError: 'str' object has no attribute 'get'when a cube'smeasures/dimensions/time_dimensionswas non-list or held non-dict members. Repro: call thelist_cubestool against a manifest whose cube has"measures": ["revenue"]— name extraction called.get("name")on the string and the tool failed.Summary
list_cubesnow ignores invalid cube entries and extracts names only from valid dictionary members.Verification
Duplicate check
Searched open/closed PRs; #2615 hardens related cube listing but not the member-array normalization in this path. No overlap.