Skip to content

fix: clarify skipped value truncation - #2631

Draft
tomatotomata wants to merge 1 commit into
Canner:mainfrom
tomatotomata:codex/issue-2629-skip-report
Draft

fix: clarify skipped value truncation#2631
tomatotomata wants to merge 1 commit into
Canner:mainfrom
tomatotomata:codex/issue-2629-skip-report

Conversation

@tomatotomata

Copy link
Copy Markdown

Summary

Closes #2629.

  • make truncated skipped-value reprs visibly truncated and report their full repr length
  • keep the existing ten-row listing cap
  • pin the cap with a negative assertion and tighten the repr regression test

The optional translate-types symmetry test is intentionally left out so this PR stays focused on the two concrete follow-ups.

Validation

  • python -m compileall -q src/wren/utils_cli.py
  • direct _report_skipped helper checks for the marker, full length, and row cap
  • git diff --check

The repository test dependencies are not installed in this sparse checkout (sqlglot and the locked uv environment are unavailable), so the full pytest and Ruff commands could not run locally.

@github-actions github-actions Bot added python Pull requests that update Python code core labels Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 89d9c873-3f25-4955-ad33-5d624400e861

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wren-cli: mark truncated values in the skipped-row report, and pin the report cap in tests

1 participant