-
-
Notifications
You must be signed in to change notification settings - Fork 122
Restrict organization management email updates #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
slashdevcorpse
wants to merge
4
commits into
Cap-go:main
Choose a base branch
from
slashdevcorpse:codex/capgo-management-email-authz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d61100f
Restrict organization management email updates
slashdevcorpse 77170ba
Block direct management email table writes
slashdevcorpse 90a5e64
Rename management email migration timestamp
slashdevcorpse 18cf36e
test: reuse cached auth in organization regressions
slashdevcorpse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
supabase/migrations/20260510221027_restrict_org_management_email_updates.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| CREATE OR REPLACE FUNCTION "public"."prevent_org_management_email_non_super_admin_update"() | ||
| RETURNS trigger | ||
| LANGUAGE "plpgsql" | ||
| SECURITY DEFINER | ||
| SET "search_path" TO '' | ||
| AS $$ | ||
| DECLARE | ||
| v_request_user uuid; | ||
| BEGIN | ||
| IF NEW.management_email IS NOT DISTINCT FROM OLD.management_email THEN | ||
| RETURN NEW; | ||
| END IF; | ||
|
|
||
| IF (SELECT auth.role()) = 'service_role' THEN | ||
| RETURN NEW; | ||
| END IF; | ||
|
|
||
| v_request_user := public.get_identity_org_allowed('{all,write}'::public.key_mode[], OLD.id); | ||
|
|
||
| IF v_request_user IS NULL OR NOT public.check_min_rights( | ||
| 'super_admin'::public.user_min_right, | ||
| v_request_user, | ||
| OLD.id, | ||
| NULL::character varying, | ||
| NULL::bigint | ||
| ) THEN | ||
| RAISE EXCEPTION 'Only organization super admins can update the management email' | ||
| USING ERRCODE = '42501'; | ||
| END IF; | ||
|
|
||
| RETURN NEW; | ||
| END; | ||
| $$; | ||
|
|
||
| ALTER FUNCTION "public"."prevent_org_management_email_non_super_admin_update"() OWNER TO "postgres"; | ||
| REVOKE ALL ON FUNCTION "public"."prevent_org_management_email_non_super_admin_update"() FROM PUBLIC; | ||
| REVOKE ALL ON FUNCTION "public"."prevent_org_management_email_non_super_admin_update"() FROM "anon"; | ||
| REVOKE ALL ON FUNCTION "public"."prevent_org_management_email_non_super_admin_update"() FROM "authenticated"; | ||
| GRANT ALL ON FUNCTION "public"."prevent_org_management_email_non_super_admin_update"() TO "service_role"; | ||
|
|
||
| DROP TRIGGER IF EXISTS "prevent_org_management_email_non_super_admin_update" ON "public"."orgs"; | ||
| CREATE TRIGGER "prevent_org_management_email_non_super_admin_update" | ||
| BEFORE UPDATE OF "management_email" ON "public"."orgs" | ||
| FOR EACH ROW | ||
| EXECUTE FUNCTION "public"."prevent_org_management_email_non_super_admin_update"(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.