refactor: rename semantic layers (guild→org, channel→team, member→user)#248
Open
thrcle wants to merge 4 commits into
Open
refactor: rename semantic layers (guild→org, channel→team, member→user)#248thrcle wants to merge 4 commits into
thrcle wants to merge 4 commits into
Conversation
Discord-specific 'guild/channel/member' terminology leaked into the business semantic layer, making the API confusing for non-Discord contexts. Replace with domain-neutral names: guild → org (organisation-wide scope) channel → team (channel/team scope) member → user (personal override scope) KV key format, FedEntry.layer values, tool parameter enums, Discord command defaults, and all tests updated. Existing stored entries can be migrated with the one-off script in the PR description. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- docs/USAGE.md: remove /ingest ref:파일명 row (path traversal risk), remove false admin-only claim on /setup, add /help to command table, fix layer names in FAQ to match new org/team/user naming - commands.py: remove '(관리자)' label from DB connection section, fix '채널에서' → '멘션하거나 스레드에서' to match actual bot behaviour, update layer example in help text to new names Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
명시적으로 layer를 지정하지 않으면 팀 단위에 저장되도록 기본값 변경. bottom-to-top 용어 관리 흐름과 일치: 팀 단위로 쌓인 후 org로 승격. user 레이어는 팀 정의와 다르게 쓸 때만 명시적으로 선택. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
Discord 내부 용어인
guild/channel/member가 비즈니스 시맨틱 레이어에 그대로 노출되고 있어, 플랫폼 중립적인 이름으로 교체했습니다.guildorgchannelteammemberuserterm_custom기본 저장 레이어 변경layer를 명시하지 않으면
user대신team에 저장되도록 기본값 변경.bottom-to-top 용어 관리 흐름에 맞게: 팀 단위로 쌓인 후 org로 승격.
user레이어는 팀 정의와 다르게 쓸 때만 명시적으로layer:user지정.수정 파일
semantic_federation.py—_LAYERS,_validate_layer,_resolve_entry, tool spec enum, KV 키 로직, 기본 레이어값confirm_ingest.py,org_setup.py— layer 문자열 리터럴PR #247 리뷰어 피드백 반영 (이 PR에 포함)
docs/USAGE.md—/ingest ref:파일명줄 제거,/setup관리자 전용 표기 제거, 커맨드 표에/help추가commands.py—(관리자)표기 제거, "채널에서" → "멘션하거나 스레드에서"기존 배포 환경
KV 키 포맷이 변경되므로 배포 후 마이그레이션 스크립트 1회 실행 필요. (PR 코멘트에 첨부)
테스트 체크리스트
uv run pytest -q)/term_custom기본값 team 저장 확인/term_custom layer:org관리자 권한 체크 정상 동작🤖 Generated with Claude Code