Repository navigation
refactor: drop underscore prefix from private fields - #10208
Merged
Merged
Conversation
Our AGENTS.md officially states to not use underscore prefix for private fields: > Private fields: No underscore prefix (use private dirty, not private _dirty) [Source](https://github.com/ChainSafe/lodestar/blob/ef457417bd636749ea397413083f6977422adee1/AGENTS.md#general-conventions) This commit just cleans up existing patterns Raised in #10189 (comment)
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
twoeths
approved these changes
Sep 29, 2026
Member
Author
|
e2e failures seem to be flaky tests; have to do with some timing sensitive tests introduced with the new builder mechanism. might have a fix coming up. My claude says:
|
nflaig
approved these changes
Sep 29, 2026
nflaig
left a comment
nflaig
left a comment
Member
There was a problem hiding this comment.
makes sense for all these changes, I had similar issue that AI refused to use underscore prefix when adding new fields to BeaconStateView, but the naming is more warranted there compared to the renames in this PR
Member
|
馃帀 This PR is included in v1.50.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our AGENTS.md officially states to not use underscore prefix for private fields:
Source
This commit just cleans up existing patterns
Raised in #10189 (comment)
Description
clean up existing patterns of private underscores
AI Assistance Disclosure
autofixed with claude