Skip to content

fix: preserve repeated blob matches in getBlobs#9333

Open
solanaXpeter wants to merge 1 commit into
ChainSafe:unstablefrom
solanaXpeter:fix-getblobs-repeated-matches
Open

fix: preserve repeated blob matches in getBlobs#9333
solanaXpeter wants to merge 1 commit into
ChainSafe:unstablefrom
solanaXpeter:fix-getblobs-repeated-matches

Conversation

@solanaXpeter
Copy link
Copy Markdown

Motivation

getBlobs currently collapses repeated versioned hash matches to the first index, which drops valid blob occurrences when a block repeats the same commitment.

Description

  • preserve every blob index that matches a requested versioned hash
  • keep results grouped by request order while preserving block order within each hash group
  • add focused coverage for repeated-hash selection

No linked issue.

AI Assistance Disclosure

  • External Contributors: I have read the contributor guidelines and disclosed my usage of AI below.
  • AI assistance used for implementation drafting and local validation.

@solanaXpeter solanaXpeter requested a review from a team as a code owner May 6, 2026 13:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logic for retrieving blob indices by versioned hashes into a reusable utility function, getBlobIndicesByVersionedHashes. It replaces inline implementations in the beacon blocks API with this new function and adds corresponding unit tests. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant