test: deneb and electra gossip validation spec tests#9372
Draft
nflaig wants to merge 8 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements and refines gossip validation for blob sidecars to align with the Deneb specification, including tracking seen sidecar tuples, validating proposer indices, and checking finalized ancestors. It also updates attestation slot range verification for EIP-7045 and adds pre-Capella checks for BLS-to-execution changes. Feedback suggests updating a comment to correctly describe the sidecar tracking tuple and reordering validation steps to perform the expensive KZG proof verification after the proposer check to improve efficiency.
Comment on lines
+190
to
+207
| // [REJECT] The sidecar is proposed by the expected proposer_index | ||
| // (if shuffling is not available, IGNORE instead and MAY be queued for later) | ||
| const blockState = await chain.regen | ||
| .getBlockSlotState(parentBlock, blobSlot, {dontTransferCache: true}, RegenCaller.validateGossipBlock) | ||
| .catch(() => { | ||
| throw new BlobSidecarGossipError(GossipAction.IGNORE, { | ||
| code: BlobSidecarErrorCode.PARENT_UNKNOWN, | ||
| parentRoot, | ||
| blockRoot: blockHex, | ||
| slot: blobSlot, | ||
| }); | ||
| }); | ||
| if (blockState.getBeaconProposer(blobSlot) !== proposerIndex) { | ||
| throw new BlobSidecarGossipError(GossipAction.REJECT, { | ||
| code: BlobSidecarErrorCode.INCORRECT_PROPOSER, | ||
| proposerIndex, | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
The proposer index validation (which may involve an expensive state regeneration via regen.getBlockSlotState) is currently performed after the expensive KZG proof verification (line 171).
Following the spec's recommended validation order, the proposer check should be performed before the blob (KZG) validation. If the proposer is incorrect, the sidecar should be rejected immediately without wasting CPU cycles on KZG verification.
Member
Author
There was a problem hiding this comment.
our check is as per spec, this is also dead code, generally we should follow spec order unless spec has a order that doesn't make sense in terms of running cheap vs. expensive checks first
Member
Author
There was a problem hiding this comment.
but this needs more review, ideally we wanna run cheap checks first
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
changed the title
lodekeeper
added a commit
to lodekeeper/lodestar
that referenced
this pull request
May 30, 2026
Adds runner support for the fulu `gossip_data_column_sidecar` networking spec tests from consensus-specs PR ChainSafe#5246. Mirrors the existing `gossip_blob_sidecar` arm: SSZ-decodes `fulu.DataColumnSidecar` and invokes `validateGossipFuluDataColumnSidecar` with the fixture's `subnet_id`. Builds on top of ChainSafe#9372. Does not address `gossip_partial_data_column_sidecar` (optional feature) nor the open `gossip_beacon_block__valid_at_blob_parameters_limit` zero-parent harness gap. 🤖 Generated with AI assistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ethereum/consensus-specs#5146 and ethereum/consensus-specs#5238