feat: report parent_block_hash for safe/finalized post-Gloas#9393
Open
wemeetagain wants to merge 1 commit into
Open
feat: report parent_block_hash for safe/finalized post-Gloas#9393wemeetagain wants to merge 1 commit into
wemeetagain wants to merge 1 commit into
Conversation
Implements consensus-specs PR-5197. Post-Gloas, engine_forkchoiceUpdated must report the bid's parent_block_hash as both safeBlockHash and finalizedBlockHash rather than the block's own execution payload hash: under ePBS the safe/finalized block's own payload may not yet be confirmed canonical, but its parent EL block has been. Adds getFinalizedExecutionBlockHash to mirror getSafeExecutionBlockHash and switches all five FCU callsites to the new fork-aware helpers.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logic to correctly handle execution block hashes for the engine_forkchoiceUpdated call in preparation for the Gloas fork. It adds a new utility function getFinalizedExecutionBlockHash and refactors getSafeExecutionBlockHash to return the parent_block_hash for Gloas blocks, ensuring compliance with the updated consensus specifications. These utilities are integrated across the beacon node's block import and production flows, and new unit tests have been added to verify the logic for both pre-Gloas and post-Gloas scenarios. I have no feedback to provide.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
ensi321
reviewed
May 22, 2026
| if (isGloasBlock(block)) { | ||
| return block.parentBlockHash as RootHex; | ||
| } | ||
| return block.executionPayloadBlockHash ?? HEX_ZERO_HASH; |
Contributor
There was a problem hiding this comment.
I think doing ?? HEX_ZERO_HASH silences an issue in the event that something is wrong in our fork choice.
We probably need to add a log if we fall back to HEX_ZERO_HASH. I think prysm is having an issue like this https://discord.com/channels/595666850260713488/892088344438255616/1505929876136530021
|
|
||
| function getExecutionBlockHashForFCU(block: ProtoBlock): RootHex { | ||
| if (isGloasBlock(block)) { | ||
| return block.parentBlockHash as RootHex; |
Contributor
There was a problem hiding this comment.
Don't really like this cast
Can we do export function isGloasBlock(block: ProtoBlock): block is ProtoBlock & {parentBlockHash: RootHex}?
nflaig
reviewed
May 30, 2026
| return getExecutionBlockHashForFCU(forkChoice.getFinalizedBlock()); | ||
| } | ||
|
|
||
| function getExecutionBlockHashForFCU(block: ProtoBlock): RootHex { |
Member
There was a problem hiding this comment.
why is the "for fcu" part relevant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Implements consensus-specs PR-5197. Post-Gloas, engine_forkchoiceUpdated must report the bid's parent_block_hash as both safeBlockHash and finalizedBlockHash rather than the block's own execution payload hash: under ePBS the safe/finalized block's own payload may not yet be confirmed canonical, but its parent EL block has been.
Adds getFinalizedExecutionBlockHash to mirror getSafeExecutionBlockHash and switches all five FCU callsites to the new fork-aware helpers.
AI Assistance Disclosure