fix: validate execution payload bids against parent branch state#9409
Open
nflaig wants to merge 3 commits into
Open
fix: validate execution payload bids against parent branch state#9409nflaig wants to merge 3 commits into
nflaig wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors execution payload bid validation by deferring state retrieval until after parent block checks, using the bid's parent branch state for builder checks. It also wraps the builder retrieval in a try-catch block to reject the bid with an appropriate error if the builder is not found. The review feedback suggests rejecting the bid immediately if the bid slot is less than or equal to the parent block slot to prevent DoS vectors, and logging the error when state regeneration fails.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This was referenced May 29, 2026
wemeetagain
pushed a commit
that referenced
this pull request
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builder bid validation is branch specific as builder state can differ across branches due to exits and balance changes. This means using the head state to validate
isActiveBuilder/canBuilderCoverBidis incorrect, we always need to load the state of the parent block as referenced in the bid viaparentBlockRoot.