feat: implement EIP-8045 exclude slashed validators from proposing#9422
Open
nflaig wants to merge 2 commits into
Open
feat: implement EIP-8045 exclude slashed validators from proposing#9422nflaig wants to merge 2 commits into
nflaig wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the processProposerLookahead function to exclude slashed validators from proposing under EIP-8045, specifically when the fork is greater than or equal to ForkSeq.gloas. It filters shuffling.activeIndices using the FLAG_UNSLASHED flag before passing them to computeProposerIndices. There are no review comments, so I have no feedback to provide.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://eips.ethereum.org/EIPS/eip-8045