Skip to content

feat: Add helper tool#28

Open
phako wants to merge 1 commit into
masterfrom
jgeorg/add-helper-tool
Open

feat: Add helper tool#28
phako wants to merge 1 commit into
masterfrom
jgeorg/add-helper-tool

Conversation

@phako

@phako phako commented May 15, 2025

Copy link
Copy Markdown
Member

This is supposed to bootstrap a very simple generic server that just
mappes the device into the control system, generating a 1:1 logical name
mapping

@phako phako self-assigned this May 15, 2025
@phako phako requested review from killenb, mhier and nshehz May 15, 2025 06:56
Comment thread tools/bootstrap-generic-server.py Outdated
Comment thread tools/bootstrap-generic-server.py

@killenb killenb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of reminds me of pogo. We somehow have too many files to touch, with too much boiler plate stuff that just "has to be like that".

The biggest benefit definitely is the creation of the xlmap. For the others I don't know if a working example with code comments would not be more useful.

What is also missing is the step that you don't want to xlmap everything. Currently you have to throw out 90 % of the registers. From the workflow it would be ideal to add one step to the "import map file" feature of the lmap editor: A wizard with a list of all registers with tick-marks where you quickly check the ones you want to import. And this adds to the existing xlmap, so you can repeat it. But that's another topic.

import deviceaccess as da
import sys

try:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the try/catch add any value? Python prints the exception message anyway.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was not to have the whole python backtrace in the device statusMessage variable

Comment thread tools/bootstrap-generic-server.py Outdated
Comment thread tools/bootstrap-generic-server.py Outdated
This is supposed to bootstrap a very simple generic server that just
mappes the device into the control system, generating a 1:1 logical name
mapping
@phako phako force-pushed the jgeorg/add-helper-tool branch from 37b5404 to bdf5e52 Compare June 4, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants