fix: 3 Arch-related script fixes (Waydroid, MyBash pkg mgr, GRUB auto-refresh) by thepinak503 · Pull Request #1294 · ChrisTitusTech/linutil

thepinak503 · 2026-05-24T12:33:22Z

Summary

Three independent fixes for Arch Linux user scripts.

#1067 — Waydroid grep syntax

Simplified the kernel detection grep in waydroid-setup.sh. Old ERE pattern used (|...) alternation with empty match — fragile and confusing. Replaced with simple piped greps: grep '^linux' | grep -v '-headers' | grep -v '-firmware'.

#1255 — MyBash: install starship/fzf/zoxide via package manager

mybash-setup.sh now tries the system package manager first for starship, fzf, and zoxide. Falls back to curl/git only if the package manager fails. Added a shared _install_pkg helper matching the pattern used by installDepend.

#1220 — GRUB theme auto-refresh

grub-theme.sh now runs grub-mkconfig -o /boot/grub/grub.cfg (or grub2-mkconfig for Fedora/RHEL) after installing the theme, so users don't have to manually refresh.

Security

All changes use existing "$ESCALATION_TOOL" pattern
Package manager + fallback preserves original behavior
No new network calls or unsafe operations

Closes #1067
Closes #1255
Closes #1220

…er, maintenance

- ChrisTitusTech#1067: Simplify waydroid kernel grep to avoid ERE syntax issues - ChrisTitusTech#1255: Use package manager for starship/fzf/zoxide before curl fallback - ChrisTitusTech#1220: Auto-run grub-mkconfig after GRUB theme installation Closes ChrisTitusTech#1067, ChrisTitusTech#1255, ChrisTitusTech#1220

technicks89

A few of the tools here would make sense to have available for all Distros. Updating to support other distros (apt-get/nala, dnf, zypper, etc). move to system-setup root instead of arch folder

technicks89 · 2026-05-24T19:10:09Z

zram-generator is available for other distros. Makes sense to add them to this and move this outside the arch folder. I think this makes more sense in the utilities folder. @Abs313a @koibtw Thoughts?

technicks89 · 2026-05-24T19:13:20Z

pipewire is available on most distros and this should also be updated and moved into system-setup root folder

…distro support

thepinak503 · 2026-05-25T06:31:51Z

Addressed review feedback from @technicks89:

pipewire-setup.sh: Added cross-distro package manager support (pacman, apt/nala, dnf, zypper, apk, xbps, eopkg) and moved from arch/ to system-setup/ root so it's available to all distros.
zram-setup.sh: Same treatment — cross-distro case $PACKAGER block (uses systemd-zram-generator on Debian/Ubuntu, zram-generator elsewhere) and moved to root.
tab_data.toml: Entries moved from the Arch section to root-level [[data]] entries so they show up for all distros.

Kept pacman-config.sh, snapshot-setup.sh, and system-maintenance.sh in arch/ since they use Arch-specific commands/paths (pacman.conf/makepkg.conf, paccache, snap-pac/grub-btrfs).

technicks89 · 2026-05-25T11:12:12Z

+        pacman) "$ESCALATION_TOOL" "$PACKAGER" -S --needed --noconfirm "$1" ;;
+        apk)    "$ESCALATION_TOOL" "$PACKAGER" add "$1" ;;
+        xbps-install) "$ESCALATION_TOOL" "$PACKAGER" -Sy "$1" ;;
+        *)      "$ESCALATION_TOOL" "$PACKAGER" install -y "$1" ;;


Recommend change *) to dnf|apt-get|nala|zypper, and using * for flatpak(if available) or note of unsupported package manager

technicks89 · 2026-05-25T11:14:43Z

+        *)
+            "$ESCALATION_TOOL" "$PACKAGER" install -y pipewire wireplumber


Recommend change *) to flatpak(if available) or note of unsupported package manager

technicks89 · 2026-05-25T11:16:57Z

+        *)
+            "$ESCALATION_TOOL" "$PACKAGER" install -y zram-generator


Recommend change *) to flatpak(if available) or note of unsupported package manager

…rted in fallback

thepinak503 · 2026-05-25T11:28:12Z

Addressed review feedback from @technicks89's second review:

mybash-setup.sh: Changed _install_pkg *) fallback to explicitly list dnf|apt-get|nala|zypper|eopkg for install -y, with *) now returning 1 (triggering the existing curl/git fallback) instead of blindly running an unknown package manager.
pipewire-setup.sh & zram-setup.sh: Replaced the *) catch-all that blindly ran $PACKAGER install -y with an explicit unsupported message + exit, since all known package managers are already handled in specific branches.

technicks89 · 2026-05-25T12:23:50Z

+            "$ESCALATION_TOOL" "$PACKAGER" install -y pipewire pipewire-pulse wireplumber
+            ;;
+        dnf)
+            "$ESCALATION_TOOL" "$PACKAGER" install -y pipewire pipewire-pulse wireplumber pipewire-jack-audio-connection-kit


pipewire-pulse should be pipewire-pulseaudio

technicks89 · 2026-05-25T12:26:16Z

+            "$ESCALATION_TOOL" "$PACKAGER" install -y pipewire pipewire-pulse wireplumber pipewire-audio-client-libraries 2>/dev/null || \
+            "$ESCALATION_TOOL" "$PACKAGER" install -y pipewire pipewire-pulse wireplumber


Debian (at least 13) has pipewire-jack as well

…ire-pulseaudio for Fedora

thepinak503 · 2026-05-25T18:46:59Z

Updated pipewire-setup.sh based on feedback:

Debian (apt-get/nala): Added pipewire-jack to the install list. Debian 13 (Trixie) ships i "$ESCALATION_TOOL" "$PACKAGER" install -y pipewire pipewire-pulse wireplumber pipewire-jack-audio-connection-kitt as a separate package. It makes sense to include it. The 2>/dev/null || fallback handles older releases gracefully.
Fedora (dnf): Fixed package name from pipewire-pulse to pipewire-pulseaudio. It is the correct Fedora package name.

thepinak503 added 3 commits May 15, 2026 10:19

Add 5 Arch system setup scripts: pacman config, pipewire, zram, snapp…

b264b84

…er, maintenance

Fix shellcheck issues: remove local/bashisms, add snapper safety guard

deb36cf

thepinak503 requested a review from ChrisTitusTech as a code owner May 24, 2026 12:33

github-actions Bot added the script label May 24, 2026

technicks89 reviewed May 24, 2026

View reviewed changes

technicks89 mentioned this pull request May 24, 2026

Add 5 Arch Linux system setup scripts #1283

Closed

1 task

refactor: move pipewire/zram scripts to system-setup root with cross-…

07490ba

…distro support

fix: bump ParallelDownloads to 20 in pacman config

022e9be

technicks89 suggested changes May 25, 2026

View reviewed changes

fix: explicitly list known pkg managers in _install_pkg, note unsuppo…

54ff34c

…rted in fallback

technicks89 suggested changes May 25, 2026

View reviewed changes

fix: add pipewire-jack for Debian 13+, rename pipewire-pulse to pipew…

0881152

…ire-pulseaudio for Fedora

technicks89 approved these changes May 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 3 Arch-related script fixes (Waydroid, MyBash pkg mgr, GRUB auto-refresh)#1294

fix: 3 Arch-related script fixes (Waydroid, MyBash pkg mgr, GRUB auto-refresh)#1294
thepinak503 wants to merge 7 commits into
ChrisTitusTech:mainfrom
thepinak503:arch-three-fixes

thepinak503 commented May 24, 2026

Uh oh!

technicks89 left a comment

Uh oh!

technicks89 May 24, 2026

Uh oh!

technicks89 May 24, 2026

Uh oh!

thepinak503 commented May 25, 2026

Uh oh!

technicks89 May 25, 2026

Uh oh!

technicks89 May 25, 2026

Uh oh!

technicks89 May 25, 2026

Uh oh!

thepinak503 commented May 25, 2026

Uh oh!

technicks89 May 25, 2026

Uh oh!

technicks89 May 25, 2026

Uh oh!

thepinak503 commented May 25, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		*)
		"$ESCALATION_TOOL" "$PACKAGER" install -y pipewire wireplumber

Conversation

thepinak503 commented May 24, 2026

Summary

#1067 — Waydroid grep syntax

#1255 — MyBash: install starship/fzf/zoxide via package manager

#1220 — GRUB theme auto-refresh

Security

Uh oh!

technicks89 left a comment

Choose a reason for hiding this comment

Uh oh!

technicks89 May 24, 2026

Choose a reason for hiding this comment

Uh oh!

technicks89 May 24, 2026

Choose a reason for hiding this comment

Uh oh!

thepinak503 commented May 25, 2026

Uh oh!

technicks89 May 25, 2026

Choose a reason for hiding this comment

Uh oh!

technicks89 May 25, 2026

Choose a reason for hiding this comment

Uh oh!

technicks89 May 25, 2026

Choose a reason for hiding this comment

Uh oh!

thepinak503 commented May 25, 2026

Uh oh!

technicks89 May 25, 2026

Choose a reason for hiding this comment

Uh oh!

technicks89 May 25, 2026

Choose a reason for hiding this comment

Uh oh!

thepinak503 commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thepinak503 commented May 25, 2026 •

edited

Loading