feat: add screencast fps option#2312
Conversation
c4943e1 to
f07fbee
Compare
|
Validation refreshed on the current head: git diff --check origin/main...HEAD
npm run test -- tests/tools/screencast.test.ts tests/cli.test.ts
npm run check-formatAll three passed locally. |
f07fbee to
ff8a821
Compare
|
Rebased this branch onto the current Validation:
|
f126440 to
7aec640
Compare
|
Thanks for your pr! Since the direction for the linked issue #2291 hasn't been fully confirmed yet, let's hold off on merging or closing it for now. We can keep this on hold until we get definitive confirmation on the final direction |
|
I ran the measurement from my #2291 comment against this PR's current branch directly, using the built MCP server rather than calling Puppeteer on its own. The server was driven through the MCP path from In one sweep, the observed post-GC RSS growth was approximately:
The growth was again concentrated in Under this machine and workload, the observed crossover was between 15 and 20 FPS. More importantly for this PR, Happy to repeat the measurement against a revised implementation or run additional durations if useful. Ayrton R. Goodman |
55150a8 to
da28be5
Compare
da28be5 to
cb97dee
Compare
Addresses #2291.
Summary
--experimental-screencast-fpsoption for screencast recording--experimental-screencastscreencast()callTesting
git diff --check origin/main...HEADnpm run check-formatnpm run typechecknpm test -- --test-only tests/tools/screencast.test.ts tests/cli.test.ts