test: fail if file does not exist#2369
Open
Lightning00Blade wants to merge 3 commits into
Open
Conversation
OrKoN
reviewed
Jul 15, 2026
OrKoN
left a comment
OrKoN
left a comment
Collaborator
There was a problem hiding this comment.
This will make the default test run always fail on a clean build (Additionally, npm build might not work after npm run bundle). I suggest we move this test to a separate test step (npm run test-bundle). WDYT?
Collaborator
Author
|
Separate test sound good. |
Lightning00Blade
force-pushed
the
don't-silsenc-a-failed
branch
from
July 16, 2026 13:43
b159a71 to
bce9831
Compare
OrKoN
reviewed
Jul 16, 2026
Comment on lines
+78
to
+79
| ${{ matrix.os == 'windows-latest' && '--test-concurrency=1' || '' }} | ||
| ${{ github.event_name == 'merge_group' && '--retry' || '' }} |
Collaborator
There was a problem hiding this comment.
we might not need it for one test
OrKoN
reviewed
Jul 16, 2026
| files.push('build/tests/**/*.test.js'); | ||
| const {glob} = await import('node:fs/promises'); | ||
| for await (const tsFile of glob('tests/**/*.test.ts')) { | ||
| if (tsFile.replace(/\\/g, '/') === 'tests/third_party_notices.test.ts') { |
Collaborator
There was a problem hiding this comment.
could we use https://nodejs.org/api/cli.html#--test-skip-pattern?
OrKoN
approved these changes
Jul 16, 2026
OrKoN
reviewed
Jul 16, 2026
| import {describe, it} from 'node:test'; | ||
|
|
||
| describe('THIRD_PARTY_NOTICES', () => { | ||
| it('matches snapshot if exists', t => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| it('matches snapshot', t => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given we run test locally and that this does not change often one can just run the command once in a while to fix the local setup.