feat: DI-1192 client-visible rejection messages via SSH auth banner - #50
Draft
MatthewwTN wants to merge 1 commit into
Draft
feat: DI-1192 client-visible rejection messages via SSH auth banner#50MatthewwTN wants to merge 1 commit into
MatthewwTN wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clever Coding Standards Agreement
Linear
DI-1192
Overview
use_sftp2_host_onlywhen they connect to the legacy us-west-1 host. Today a rejected login only shows the client's generic "Permission denied, please try again." — districts get no explanation of why they can no longer connect, which will drive support load during the sftp2.clever.com rollout.NewManagedServerWithErroraccepts a generator returning(ServerDriver, error); returning a nil driver with a*RejectionErrorsends its message to the client as an auth banner viassh.BannerError. All other denials (nil driver, plain/nil error) behave exactly as today.NewManagedServeris unchanged, so the other consumer (lockbox-sftp) is unaffected.ssh.BannerErrordid not exist in the previously pinned 2022 version.Testing
go buildand the package test suite pass.TestRejectionToSSHErrorcovers: banner from aRejectionError, banner from a wrappedRejectionError, trailing-newline normalization, and generic denial for nil/plain errors.Rollout
NewManagedServerWithError.Rollback
NewManagedServerWithErrorare unaffected. If clever-sftp has already adopted it, re-pin its go.mod to the prior pseudo-version as part of the revert.