fix(client): keep jumped timeline off live bottom#114
Merged
Conversation
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/vitestThe overall coverage remains at 22%, unchanged from the branch. Updated |
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-114-charm.justin-tech.workers.dev | 66c32df | pr-114 |
Tue, 16 Jun 2026 17:07:48 GMT |
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for the reopened jump-button regression in
#103.After the async jump path successfully centered the target event, the room timeline could still think it was pinned to the live bottom from the previous room state. That let the scroll handler immediately chase the bottom again and undo the jump. This change clears the bottom-pinned state before the centered jump scroll and reuses the existing short jump-settle guard so the target event stays in place.
Related repo history checked before opening this PR:
Fixes #103
Type of change
Checklist:
AI disclosure:
This PR updates the successful async jump path in
RoomTimeline.tsx. When a jumped-to event is found and the timeline scrolls it into view, the code now clears the staleatBottomstate first and starts the existing short jump scroll block before callingscrollToIndex(..., { align: 'center' }). That prevents the scroll observer from treating the room as still bottom-pinned and immediately chasing the live bottom after the jump lands. No other timeline-loading logic changes here; this is only a follow-up to keep the already-selected target event stable after the jump succeeds.