Skip to content

fix(client): keep jumped timeline off live bottom#114

Merged
Just-Insane merged 2 commits into
integrationfrom
codex/fix-jump-bottom-followup
Jun 16, 2026
Merged

fix(client): keep jumped timeline off live bottom#114
Just-Insane merged 2 commits into
integrationfrom
codex/fix-jump-bottom-followup

Conversation

@Just-Insane

Copy link
Copy Markdown
Collaborator

Description

Follow-up for the reopened jump-button regression in #103.

After the async jump path successfully centered the target event, the room timeline could still think it was pinned to the live bottom from the previous room state. That let the scroll handler immediately chase the bottom again and undo the jump. This change clears the bottom-pinned state before the centered jump scroll and reuses the existing short jump-settle guard so the target event stays in place.

Related repo history checked before opening this PR:

Fixes #103

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).
    This PR updates the successful async jump path in RoomTimeline.tsx. When a jumped-to event is found and the timeline scrolls it into view, the code now clears the stale atBottom state first and starts the existing short jump scroll block before calling scrollToIndex(..., { align: 'center' }). That prevents the scroll observer from treating the room as still bottom-pinned and immediately chasing the live bottom after the jump lands. No other timeline-loading logic changes here; this is only a follow-up to keep the already-selected target event stable after the jump succeeds.

@github-code-quality

github-code-quality Bot commented Jun 16, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: JavaScript

JavaScript / code-coverage/vitest

The overall coverage remains at 22%, unchanged from the branch.


Updated June 16, 2026 17:08 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-114-charm.justin-tech.workers.dev 66c32df pr-114 Tue, 16 Jun 2026 17:07:48 GMT

@Just-Insane Just-Insane enabled auto-merge June 16, 2026 17:08
@Just-Insane Just-Insane merged commit 17893a9 into integration Jun 16, 2026
14 checks passed
@Just-Insane Just-Insane deleted the codex/fix-jump-bottom-followup branch June 16, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jump Buttons Broken

1 participant