Skip to content

Reduce room notification chip icon size#66

Merged
Just-Insane merged 1 commit into
integrationfrom
codex/room-notification-icon-size
Jun 14, 2026
Merged

Reduce room notification chip icon size#66
Just-Insane merged 1 commit into
integrationfrom
codex/room-notification-icon-size

Conversation

@Just-Insane

Copy link
Copy Markdown
Collaborator

Description

Reduce passive room-list notification chip icons from the generic 20px chip size to the smaller 16px icon token. This keeps the Phosphor bell indicators closer to their pre-migration visual weight in the sidebar.

Related to #65

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

AI assisted the small sizing change in useRoomsNotificationPreferences: passive room-list notification mode glyphs now use the 16px sized icon helper, while menu notification icons keep their existing 20px menu sizing.

@github-code-quality

github-code-quality Bot commented Jun 14, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: JavaScript

JavaScript / code-coverage/vitest

The overall coverage in the branch remains at 21%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File 4039e34 1ef7084 +/-
src/app/hooks/u...nPreferences.ts 28% 29% +1%

Updated June 14, 2026 15:54 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@Just-Insane Just-Insane force-pushed the codex/room-notification-icon-size branch from c69f40f to 1ef7084 Compare June 14, 2026 15:51
@github-actions

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

✅ Worker preview upload completed, but Wrangler did not return a resolvable aliased preview URL.

Alias: pr-66
Commit: 1ef7084
Updated: Sun, 14 Jun 2026 15:53:46 GMT

@Just-Insane Just-Insane enabled auto-merge June 14, 2026 15:53
@Just-Insane Just-Insane merged commit 2a07df2 into integration Jun 14, 2026
14 checks passed
@Just-Insane Just-Insane deleted the codex/room-notification-icon-size branch June 14, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant