XML refactors: Simplify some attribute-related helpers#4045

Merged

clumens merged 24 commits into

ClusterLabs:mainfrom

nrwahl2:nrwahl2-acls_first

Jun 4, 2026

Commits on Apr 28, 2026

Refactor: libcrmcommon: Use a switch statement in is_mode_allowed()
nrwahl2
committed
Doc: libcrmcommon: Clarify that pcmk__element_xpath() returns non-NULL
nrwahl2
committed
Refactor: libcrmcommon: Use convenience helpers in implicitly_allowed()
nrwahl2
committed
Refactor: libcrmcommon: Walk up the tree in implicitly_allowed()
nrwahl2
committed
Refactor: libcrmcommon, libpe_status: Drop strncmp() calls
nrwahl2
committed
Refactor: libcrmcommon: Drop a redundant check in pcmk__xa_remove()
nrwahl2
committed
Refactor: libcrmcommon: Check force arg sooner in pcmk__xa_remove()
nrwahl2
committed
Refactor: libcrmcommon: Functionize cases of new_private_data()
nrwahl2
committed
Refactor: libcrmcommon: New pcmk__xe_foreach{,_const}_attr()
nrwahl2
committed
Refactor: libcrmcommon: pcmk__xe_foreach_attr() in new_private_data()
nrwahl2
committed
Refactor: libcrmcommon: Clear flags in reset_xml_private_data()
nrwahl2
committed
Refactor: libcrmcommon: pcmk__xe_foreach_attr() in free_private_data()
nrwahl2
committed
Refactor: libcrmcommon: Use a for-loop in xml_diff_old_attrs()
nrwahl2
committed
Refactor: libcrmcommon: Unindent else block in xml_diff_old_attrs()
nrwahl2
committed
Refactor: libcrmcommon: Unindent a bit more of xml_diff_old_attrs()
nrwahl2
committed
Refactor: libcrmcommon: pcmk__xe_foreach_attr() in xml_diff_old_attrs()
nrwahl2
committed
Refactor: libcrmcommon: Drop redundant check from mark_attr_diff()
nrwahl2
committed
Refactor: libcrmcommon: Drop redundant args from mark_attr_*() functions
nrwahl2
committed
Refactor: libcrmcommon: Use for loop in mark_created_attrs()
nrwahl2
committed
Refactor: libcrmcommon: Unindent most of for loop in mark_created_attrs
nrwahl2
committed
Refactor: libcrmcommon: pcmk__xe_foreach_attr() for mark_created_attrs()
nrwahl2
committed
Refactor: libcrmcommon: New mark_attr_created()
nrwahl2
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XML refactors: Simplify some attribute-related helpers#4045

XML refactors: Simplify some attribute-related helpers#4045
clumens merged 24 commits into
ClusterLabs:mainfrom
nrwahl2:nrwahl2-acls_first

Commits on Apr 28, 2026

Refactor: libcrmcommon: Use a switch statement in is_mode_allowed()

Doc: libcrmcommon: Clarify that pcmk__element_xpath() returns non-NULL

Refactor: libcrmcommon: Use convenience helpers in implicitly_allowed()

Refactor: libcrmcommon: Walk up the tree in implicitly_allowed()

Refactor: libcrmcommon, libpe_status: Drop strncmp() calls

Refactor: libcrmcommon: Drop a redundant check in pcmk__xa_remove()

Refactor: libcrmcommon: Check force arg sooner in pcmk__xa_remove()

Refactor: libcrmcommon: Functionize cases of new_private_data()

Refactor: libcrmcommon: New pcmk__xe_foreach{,_const}_attr()

Refactor: libcrmcommon: pcmk__xe_foreach_attr() in new_private_data()

Refactor: libcrmcommon: Clear flags in reset_xml_private_data()

Refactor: libcrmcommon: pcmk__xe_foreach_attr() in free_private_data()

Refactor: libcrmcommon: Use a for-loop in xml_diff_old_attrs()

Refactor: libcrmcommon: Unindent else block in xml_diff_old_attrs()

Refactor: libcrmcommon: Unindent a bit more of xml_diff_old_attrs()

Refactor: libcrmcommon: pcmk__xe_foreach_attr() in xml_diff_old_attrs()

Refactor: libcrmcommon: Drop redundant check from mark_attr_diff()

Refactor: libcrmcommon: Drop redundant args from mark_attr_*() functions

Refactor: libcrmcommon: Use for loop in mark_created_attrs()

Refactor: libcrmcommon: Unindent most of for loop in mark_created_attrs

Refactor: libcrmcommon: pcmk__xe_foreach_attr() for mark_created_attrs()

Refactor: libcrmcommon: New mark_attr_created()

Commits on Apr 29, 2026

Refactor: various: Assert fn argument not NULL in foreach functions

Build: devel: Disable Coverity's inconsistent union warnings