Skip to content

Deprecate crm_time_period_t, and some other cleanups #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nrwahl2 wants to merge 30 commits into
base: main
Choose a base branch
from
+640 −464
Open

Deprecate crm_time_period_t, and some other cleanups #4105

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ad97a72
Refactor: libcrmcommon: Clarify days_in_month_year()
nrwahl2 Apr 11, 2026
abfe777
Refactor: libcrmcommon: Use g_date_get_days_in_month()
nrwahl2 Apr 12, 2026
074fa4a
Log: libcrmcommon: Drop unhelpful trace logs from crm_time_add_months()
nrwahl2 Apr 12, 2026
d417481
Refactor: libcrmcommon: Rename a_time and value variables in crm_time.c
nrwahl2 Apr 12, 2026
2aed776
Refactor: libcrmcommon: Rename ymd variables in crm_time_add_months()
nrwahl2 Apr 12, 2026
51dfb80
Refactor: libcrmcommon: Assert before dereferencing in iso8601.c
nrwahl2 Apr 12, 2026
56028a9
Refactor: libcrmcommon: Improve variable names in get_ordinal_days()
nrwahl2 Apr 11, 2026
a3d3d06
Refactor: libcrmcommon: Drop redundant check from parse_int()
nrwahl2 Apr 12, 2026
4136b05
Refactor: libcrmcommon: Functionizing parsing a duration element
nrwahl2 Apr 12, 2026
1f5a24f
Refactor: libcrmcommon: Drop some nesting in parse_duration_element()
nrwahl2 Apr 12, 2026
4d13563
Log: libcrmcommon: Improve no-units message in parse_duration_element()
nrwahl2 Apr 12, 2026
8be47a0
Log: libcrmcommon: Simplify overflow logging in parse_duration_element()
nrwahl2 Apr 12, 2026
5b715eb
Low: libcrmcommon: Improve crm_time_get_seconds() for durations
nrwahl2 Apr 12, 2026
82b4730
Refactor: libcrmcommon: Use g_date_is_leap_year()
nrwahl2 Apr 12, 2026
8b3bd5b
Doc: libcrmcommon: Address FIXME comment about GLib version
nrwahl2 Apr 12, 2026
17e4629
Refactor: libcrmcommon: New offset_text()
nrwahl2 Apr 12, 2026
b1f822a
Refactor: libcrmcommon: seconds_to_hms() accepts NULL seconds
nrwahl2 Apr 12, 2026
9f975cc
Refactor: tools: Drop redundant else in crm_rule.c
nrwahl2 Apr 13, 2026
fc37918
Refactor: libcrmcommon: Remove some nesting in set_effective_date()
nrwahl2 Apr 16, 2026
c2d21cd
Refactor: libpacemaker: Improve validation in set_effective_date()
nrwahl2 Apr 17, 2026
c3d4f3f
Refactor: libcrmcommon: Cast -1 to time_t for comparison
nrwahl2 Apr 26, 2026
6bf377a
Test: cts-cli: Test out-of-range year in interval specification
nrwahl2 Apr 27, 2026
49c9040
Feature: libcrmcommon: crm_time_parse_period requires years in [1, 9999]
nrwahl2 Apr 27, 2026
8be01c8
Refactor: tools: iso8601 output function doesn't use crm_time_period_t
nrwahl2 Apr 27, 2026
bd3d2fe
Refactor: tools: Drop crm_time_period_t from iso8601 CLI tool
nrwahl2 Apr 27, 2026
ef38ab1
API: libcrmcommon: Deprecate crm_time_parse_period()
nrwahl2 Apr 27, 2026
f3f3815
API: libcrmcommon: Deprecate crm_time_free_period()
nrwahl2 Apr 27, 2026
73da0e8
API: libcrmcommon: Deprecate crm_time_period_t
nrwahl2 Apr 27, 2026
e254aec
Feature: tools: crm_rule requires dates to have year between 1 and 9999
nrwahl2 Apr 13, 2026
fd21ceb
Doc: Pacemaker Explained: Document limitation of months in duration type
nrwahl2 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cts/cli/regression.dates.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,12 @@ iso8601: Invalid interval specified: 2019-01-01 00:00:00Z/P
=#=#=#= End test: Invalid period - [2019-01-01 00:00:00Z/P] - Invalid parameter (2) =#=#=#=
* Passed: iso8601 - Invalid period - [2019-01-01 00:00:00Z/P]
=#=#=#= Begin test: Invalid period - [P1Z/2019-02-20 00:00:00Z] =#=#=#=
crm_time_parse_duration error: 'P1Z/2019-02-20 00:00:00Z' is not a valid ISO 8601 time duration because 'Z' is not a valid time unit
parse_duration_element error: 'P1Z/2019-02-20 00:00:00Z' is not a valid ISO 8601 duration because 'Z' is not a valid time unit
iso8601: Invalid interval specified: P1Z/2019-02-20 00:00:00Z
=#=#=#= End test: Invalid period - [P1Z/2019-02-20 00:00:00Z] - Invalid parameter (2) =#=#=#=
* Passed: iso8601 - Invalid period - [P1Z/2019-02-20 00:00:00Z]
=#=#=#= Begin test: Invalid period - [P1YM/2019-02-20 00:00:00Z] =#=#=#=
crm_time_parse_duration error: 'P1YM/2019-02-20 00:00:00Z' is not a valid ISO 8601 time duration because no valid integer at 'M/2019-02-20 00:00:00Z'
parse_duration_element error: 'P1YM/2019-02-20 00:00:00Z' is not a valid ISO 8601 duration because no valid integer at 'M/2019-02-20 00:00:00Z'
iso8601: Invalid interval specified: P1YM/2019-02-20 00:00:00Z
=#=#=#= End test: Invalid period - [P1YM/2019-02-20 00:00:00Z] - Invalid parameter (2) =#=#=#=
* Passed: iso8601 - Invalid period - [P1YM/2019-02-20 00:00:00Z]
Expand Down
3 changes: 2 additions & 1 deletion cts/cts-cli.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# We know this is a very long file.
# pylint: disable=too-many-lines

__copyright__ = "Copyright 2024-2025 the Pacemaker project contributors"
__copyright__ = "Copyright 2024-2026 the Pacemaker project contributors"
__license__ = "GNU General Public License version 2 or later (GPLv2+) WITHOUT ANY WARRANTY"

import argparse
Expand Down Expand Up @@ -261,6 +261,7 @@ def sanitize_output(s):
(r'last_update time=".*"', r'last_update time=""'),
(r' last-rc-change=[\'"][-+A-Za-z0-9: ]*[\'"],?', r''),
(r'\(parse_date@.*\.c:[0-9]+\)', r'parse_date'),
(r'\(parse_duration_element@.*\.c:[0-9]+\)', r'parse_duration_element'),
(r'\((pcmk__.*)@.*\.c:[0-9]+\)', r'\1'),
(r'.*Relax-NG validity error : ', r''),
(r'request=".*cibadmin', r'request="cibadmin'),
Expand Down
Loading