Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London10-SAQIB_JAVED-JavaScript-Core-1-Coursework-week1 #523

Open
saqibjvd wants to merge 9 commits into
base: master
Choose a base branch
from
Open

London10-SAQIB_JAVED-JavaScript-Core-1-Coursework-week1 #523

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d0c28ff
syntax error
saqibjvd Feb 18, 2023
5a0fe97
mandotry
saqibjvd Feb 22, 2023
4bc7687
mandotary exercise
saqibjvd Feb 22, 2023
b983204
Update 1-currency-conversion.js
saqibjvd Feb 23, 2023
231019f
extra javascript
saqibjvd Feb 24, 2023
9519b4b
Update 3-magic-8-ball.js
saqibjvd Feb 24, 2023
44e89c7
Update 3-magic-8-ball.js
saqibjvd Feb 24, 2023
81740ca
extra task complete
saqibjvd Feb 24, 2023
4e2372b
Update 2-piping.js
saqibjvd Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mandatory/3-function-output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// Add comments to explain what this function does. You're meant to use Google!

// Math.random() returns a random number between 0 (inclusive), and 1 (exclusive). this code generate random number between 0 and 1 then multiply by 10.
/* Math.random() returns a random number between 0 (inclusive), and 1 (exclusive). this code generate random number between 0 and 1 then multiply by 10. */

function getRandomNumber() {
return Math.random() * 10;
}

// Add comments to explain what this function does. You're meant to use Google!

// The concat() method is used to merge two or more arrays. This method does not change the existing arrays, but instead returns a new array.
/* The concat() method is used to merge two or more arrays. This method does not change the existing arrays, but instead returns a new array. */

function combine2Words(word1, word2) {
return word1.concat(word2);
Expand Down
9 changes: 7 additions & 2 deletions mandatory/4-tax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
Sales tax is 20% of the price of the product.
*/

function calculateSalesTax() {}
function calculateSalesTax(price) {
return price + (price / 100) * 20;

@Bedi06 Bedi06 Feb 22, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Saqib , i'm doing a code review as part of homework .
What i would suggest is in case you want a more simple code you could use just return price + (price *0.2) .
But great job either way .

@saqibjvd saqibjvd Feb 23, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bedi06 thanks for your feedback.

}

/*
CURRENCY FORMATTING
Expand All @@ -17,7 +19,10 @@ function calculateSalesTax() {}
Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
*/

function addTaxAndFormatCurrency() {}
function addTaxAndFormatCurrency(price) {
let Price = calculateSalesTax(price);

@moneyinthesky moneyinthesky Mar 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but you might think about the name of this variable Price. Having 2 variables with very similar names (price and Price) might be confusing for other developers 😄

@saqibjvd saqibjvd Mar 5, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks thats evdn confusing for me too

@saqibjvd saqibjvd Mar 5, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tired to give another name before, it wasn’t working then after few tries i put price to make it working

return "£" + Price.toFixed(2);
}

/*
===================================================
Expand Down