Skip to content

London | 26-ITP-May | Raihan Sharif | Sprint 3 | Alarm Clock #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaihanSharif wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-May | Raihan Sharif | Sprint 3 | Alarm Clock #1223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ebf8fc
implement alarm clock
RaihanSharif Feb 27, 2026
5a4dc50
remove code repition. Pause previous alarm when starting new timer
RaihanSharif May 10, 2026
2e28700
Remove unused variable
RaihanSharif May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,64 @@
function setAlarm() {}
// need to set interval outside of setAlarm() so that every time the user clicks set alarm
// the previous interval is deleted. Otherwise there will be overlapping intervals
// if a user clicks on set alarm while an countdown is already active.
let intervalId = null;

function setAlarm() {
const alarmClockInput = document.getElementById("alarmSet");
const clockDisplay = document.getElementById("timeRemaining");
let secondsRemaining = parseInt(alarmClockInput.value, 10);

if (!isValidInput(secondsRemaining)) {
alert("please enter a valid positive integer!");
return;
}

clearInterval(intervalId);

Comment thread
RaihanSharif marked this conversation as resolved.
// display immediately on click;
const minutes = Math.floor(secondsRemaining / 60);
const seconds = secondsRemaining % 60;
displayTime(minutes, seconds, clockDisplay);

@cjyuan cjyuan May 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three lines of code are repeated on lines 33-35. Wouldn't it be better to compute the minutes and seconds in the displayTime() function?


intervalId = setInterval(() => {
secondsRemaining--;

if (secondsRemaining <= 0) {
clearInterval(intervalId);
displayTime(0, 0, clockDisplay);
playAlarm();
return;
}

const minutes = Math.floor(secondsRemaining / 60);
const seconds = secondsRemaining % 60;
displayTime(minutes, seconds, clockDisplay);
}, 1000);
}

// formats and displays countdown time to a supplied element
function displayTime(mins, secs, elem) {
const minsFormatted = String(mins).padStart(2, "0");
const secsFormatted = String(secs).padStart(2, "0");
elem.textContent = `Time Remaining: ${minsFormatted}:${secsFormatted}`;
}

// returns true if input is an integer, false otherwise
function isValidInput(input) {
if (input === "" || isNaN(input)) {
return false;
}

if (!Number.isInteger(input)) {
return false;
}

if (input < 0) {
Comment thread
RaihanSharif marked this conversation as resolved.
Outdated
return false;
}

return true;
}

// DO NOT EDIT BELOW HERE

Expand Down
6 changes: 3 additions & 3 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />
<input id="alarmSet" type="number" min="1" step="1" required />

<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
Expand Down
Loading